Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Commit 9ed929b

Browse files
committed
Point to BSK branch and handle new error
1 parent 2b49550 commit 9ed929b

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

Core/PixelEvent.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -624,6 +624,7 @@ extension Pixel {
624624
case syncRemoveDeviceError
625625
case syncDeleteAccountError
626626
case syncLoginExistingAccountError
627+
case syncSecureStorageReadError
627628

628629
case syncGetOtherDevices
629630
case syncGetOtherDevicesCopy
@@ -1432,6 +1433,7 @@ extension Pixel.Event {
14321433
case .syncRemoveDeviceError: return "m_d_sync_remove_device_error"
14331434
case .syncDeleteAccountError: return "m_d_sync_delete_account_error"
14341435
case .syncLoginExistingAccountError: return "m_d_sync_login_existing_account_error"
1436+
case .syncSecureStorageReadError: return "m_d_sync_secure_storage_error"
14351437

14361438
case .syncGetOtherDevices: return "sync_get_other_devices"
14371439
case .syncGetOtherDevicesCopy: return "sync_get_other_devices_copy"

Core/SyncErrorHandler.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,8 @@ public class SyncErrorHandler: EventMapping<SyncError> {
100100
Pixel.fire(pixel: .syncFailedToLoadAccount, error: error)
101101
case .failedToSetupEngine:
102102
Pixel.fire(pixel: .syncFailedToSetupEngine, error: error)
103+
case .failedToReadSecureStore(let status):
104+
Pixel.fire(pixel: .syncSecureStorageReadError, error: error)
103105
default:
104106
// Should this be so generic?
105107
let domainEvent = Pixel.Event.syncSentUnauthenticatedRequest

DuckDuckGo.xcodeproj/project.pbxproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10969,8 +10969,8 @@
1096910969
isa = XCRemoteSwiftPackageReference;
1097010970
repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
1097110971
requirement = {
10972-
kind = exactVersion;
10973-
version = 203.1.0;
10972+
branch = "graeme/send-pixel-on-sync-secure-storage-failure";
10973+
kind = branch;
1097410974
};
1097510975
};
1097610976
9F8FE9472BAE50E50071E372 /* XCRemoteSwiftPackageReference "lottie-spm" */ = {

0 commit comments

Comments
 (0)