Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Commit d9a02a3

Browse files
graemeafterxleep
andauthored
Send pixel on sync secure storage failure (#3542)
Task/Issue URL: https://app.asana.com/0/414235014887631/1208700858621924/f **Description**: This was reviewed here: #3530 and merged already to the release branch, but there's been conflicts since. So it needs an extra PR to resolve them. **Steps to test this PR**: 1. Just make sure this compiles and is pointing to latest BSK release. **Definition of Done (Internal Only)**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? **Copy Testing**: * [ ] Use of correct apostrophes in new copy, ie `’` rather than `'` **Orientation Testing**: * [ ] Portrait * [ ] Landscape **Device Testing**: * [ ] iPhone SE (1st Gen) * [ ] iPhone 8 * [ ] iPhone X * [ ] iPhone 14 Pro * [ ] iPad **OS Testing**: * [ ] iOS 15 * [ ] iOS 16 * [ ] iOS 17 **Theme Testing**: * [ ] Light theme * [ ] Dark theme --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) --------- Co-authored-by: Daniel Bernal <[email protected]>
1 parent b50b7fa commit d9a02a3

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

Core/PixelEvent.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -624,6 +624,7 @@ extension Pixel {
624624
case syncRemoveDeviceError
625625
case syncDeleteAccountError
626626
case syncLoginExistingAccountError
627+
case syncSecureStorageReadError
627628

628629
case syncGetOtherDevices
629630
case syncGetOtherDevicesCopy
@@ -1437,6 +1438,7 @@ extension Pixel.Event {
14371438
case .syncRemoveDeviceError: return "m_d_sync_remove_device_error"
14381439
case .syncDeleteAccountError: return "m_d_sync_delete_account_error"
14391440
case .syncLoginExistingAccountError: return "m_d_sync_login_existing_account_error"
1441+
case .syncSecureStorageReadError: return "m_d_sync_secure_storage_error"
14401442

14411443
case .syncGetOtherDevices: return "sync_get_other_devices"
14421444
case .syncGetOtherDevicesCopy: return "sync_get_other_devices_copy"

Core/SyncErrorHandler.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,8 @@ public class SyncErrorHandler: EventMapping<SyncError> {
100100
Pixel.fire(pixel: .syncFailedToLoadAccount, error: error)
101101
case .failedToSetupEngine:
102102
Pixel.fire(pixel: .syncFailedToSetupEngine, error: error)
103+
case .failedToReadSecureStore:
104+
Pixel.fire(pixel: .syncSecureStorageReadError, error: error)
103105
default:
104106
// Should this be so generic?
105107
let domainEvent = Pixel.Event.syncSentUnauthenticatedRequest

0 commit comments

Comments
 (0)