Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance onPressed callbacks to support better analytics #140

Open
sishyanet opened this issue Jan 14, 2023 · 1 comment
Open

Enhance onPressed callbacks to support better analytics #140

sishyanet opened this issue Jan 14, 2023 · 1 comment

Comments

@sishyanet
Copy link

I'd like to add some analytics to the intro slider, and want to suggest a couple of changes. Happy to send a PR if you think these are good ideas:

  1. onNextPress callback should be a function that takes a parameter (int) that gives the index of the slide the user is swiping to.
  2. Add a new callback, onPrevPress, to make it consistent with the other buttons, taking a parameter (int) as above.
  3. Add a callback, onSlide, that takes a parameter (int), and which the caller can listen to for whenever the user enters a different slide.

This will be helpful to collect analytics about which slides users are visiting, and/or performing A/B tests to figure out the performance of different slide designs.

@sishyanet sishyanet changed the title Enhance onPressed callbacks Enhance onPressed callbacks to support better analytics Jan 14, 2023
@duytq94
Copy link
Owner

duytq94 commented Jan 18, 2023

Hi, thanks for your raised issue.
I think 1 & 2 are fine, but at 3 we already have onTabChangeCompleted, is it got what you need?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants