Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[util][testutil] Add container test package by shell out to docker cli #124

Closed
2 tasks done
at15 opened this issue Mar 4, 2020 · 0 comments · Fixed by #125
Closed
2 tasks done

[util][testutil] Add container test package by shell out to docker cli #124

at15 opened this issue Mar 4, 2020 · 0 comments · Fixed by #125
Assignees
@at15
Labels
pkg/util
Milestone
0.0.14

Comments

@at15
Copy link
Member

at15 commented Mar 4, 2020 •
edited
Loading

It's a simplified version of dyweb/go.ice#56 where I tried to create a docker client without importing entire docker repo. gommon itself also need container testing package for wait for it #122 .

Since I only need limited functionality, simply checking exit code and pull should be good.

  • create a container (shell out to docker run)
  • remove a container
@at15 at15 added the pkg/util label Mar 4, 2020
@at15 at15 added this to the 0.0.14 milestone Mar 4, 2020
@at15 at15 self-assigned this Mar 4, 2020
at15 added a commit that referenced this issue Mar 4, 2020
@at15
[testutil] Add start container #124
551f817 
- though the container is NOT removed after the test is finised ...
@at15 at15 mentioned this issue Mar 4, 2020
Merged
2 tasks
at15 added a commit that referenced this issue Mar 6, 2020
@at15
[testutil] Stop container using docker rm -f #124
df1d278 
- kill the docker run process does not work
- add labels to created container so they can be cleaned in batch
at15 added a commit that referenced this issue Mar 6, 2020
@at15
[testutil] Run docker pull before run #124
e23c62c 
- this should make test on Travis fail less
@at15 at15 closed this as completed in #125 Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@at15 at15

Labels
pkg/util
Projects
None yet
Milestone
0.0.14
Development

Successfully merging a pull request may close this issue.

[testutil] Add container test dyweb/gommon
1 participant
@at15