fix(queries): options default to object

Author: line-o

components/queries.js

@@ -13,7 +13,7 @@ function read (client, query, options = {}) {
   const limit = options.limit || 1
   const start = options.start || 1 // yes, start it seems to be 1-based
 
-  // remmove them from options as they cause NPEs in exist-db XML-RPC 
+  // remmove them from options as they cause NPEs in exist-db XML-RPC
   delete options.limit
   delete options.start
 
@@ -27,7 +27,7 @@ function read (client, query, options = {}) {
  * @param {Object} options
  * @returns {Promise}
  */
-function execute (client, queryStringOrBuffer, options) {
+function execute (client, queryStringOrBuffer, options = {}) {
   return client.promisedMethodCall('executeQuery', [queryStringOrBuffer, options])
 }
 
@@ -51,7 +51,7 @@ function releaseResult (client, handle) {
   return client.promisedMethodCall('releaseQueryResult', [handle])
 }
 
-function readAll (client, queryStringOrBuffer, options) {
+function readAll (client, queryStringOrBuffer, options = {}) {
   let resultHandle = -1
   let resultPages = -1
   let results, error

spec/tests/queries.js

@@ -70,6 +70,25 @@ test('call queryAll method', function (t) {
     })
 })
 
+test('call queryAll method without options', function (t) {
+  const db = connect(envOptions)
+  const queryString = 'for $i in (1,2) return $i + 10'
+  const expectedResult = '11,12'
+
+  db.queries.readAll(queryString)
+    .then(function (result) {
+      const csv = result.pages.map(function (p) { return p.toString() }).join(',')
+      t.equal(result.pages.length, result.hits, 'all pages retrieved')
+      t.equal(csv, expectedResult, 'got expected result')
+      t.deepEqual(result.options, {}, 'options default to empty object')
+      t.end()
+    })
+    .catch(function (e) {
+      t.fail(e)
+      t.end()
+    })
+})
+
 test('run query, expect XML', function (t) {
   t.skip('not implemented yet')
   t.end()