Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify formatter workflow? #74

Open
IndrajeetPatil opened this issue Feb 4, 2025 · 3 comments
Open

Simplify formatter workflow? #74

IndrajeetPatil opened this issue Feb 4, 2025 · 3 comments

Comments

@IndrajeetPatil
Copy link
Member

@etiennebacher Did you notice any big differences between styler and air? Should we switch?

cf. https://github.com/etiennebacher/flint/blob/main/.github/workflows/format.yml

@etiennebacher
Copy link
Member

etiennebacher commented Feb 4, 2025

I really like air, it is much much faster (workflow runs in ~10 seconds). It is opinionated but I like the output. I think we should switch our formatter workflow to use air eventually but there are a couple of things to check first:

@IndrajeetPatil
Copy link
Member Author

Thanks for the summary!

Okay. Let's wait for a bit before switching.

@etiennebacher
Copy link
Member

etiennebacher commented Mar 6, 2025

air is now released but I'm actually not sure we should transition. I use it in all my projects but styler has more features (checking pipe consistency for instance) so I think that even if we used air for formatting we would still need to rely on a styler workflow anyway.

(Also, changing the formatter workflow would require everyone to set up the new tooling, so it's not as easy as me using it in my own projects.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants