eslint updates. yarn lock. commonjs support

Author: ebidel

.eslintignore

@@ -0,0 +1,2 @@
+node_modules/
+dist/

.eslintrc

@@ -0,0 +1,19 @@
+module.exports = {
+  "extends": ["eslint:recommended", "google"],
+  "env": {
+    "browser": true
+  },
+  "rules": {
+    "quotes": [2, "single"],
+    "prefer-const": 2,
+    "max-len": [2, 100, {
+      "ignoreComments": true,
+      "ignoreUrls": true,
+      "tabWidth": 2
+    }],
+  },
+  "globals": {
+    "ga": true,
+    "window": true
+  }
+}

.eslintrc.js

@@ -1,5 +1,5 @@
 /*!
- * Copyright 2016 Copyright (c) 2016 Eric Bidelman. All rights reserved.
+ * Copyright 2017 Copyright (c) 2016 Eric Bidelman. All rights reserved.
 
  * @version v0.0.6
  *
@@ -18,4 +18,5 @@
 var _start=new WeakMap,_end=new WeakMap,Metric=function(a){if(!a)throw Error("Please provide a metric name");if(!Metric.supportsPerfMark&&(console.warn("Timeline won't be marked for \""+a+'".'),!Metric.supportsPerfNow))throw Error("This library cannot be used in this browser.");this.name=a};Metric.prototype.log=function(){console.info(this.name,this.duration,"ms");return this};
 Metric.prototype.logAll=function(a){a=void 0===a?this.name:a;if(Metric.supportsPerfNow)for(var b=performance.getEntriesByName(a),c=0;c<b.length;++c)console.info(a,b[c].duration,"ms");return this};Metric.prototype.start=function(){if(_start.get(this))return console.warn("Recording already started."),this;_start.set(this,performance.now());Metric.supportsPerfMark&&performance.mark("mark_"+this.name+"_start");return this};
 Metric.prototype.end=function(){if(_end.get(this))return console.warn("Recording already stopped."),this;_end.set(this,performance.now());if(Metric.supportsPerfMark){var a="mark_"+this.name+"_start",b="mark_"+this.name+"_end";performance.mark(b);performance.measure(this.name,a,b)}return this};Metric.prototype.sendToAnalytics=function(a,b,c){b=void 0===b?this.name:b;c=void 0===c?this.duration:c;window.ga?0<=c&&ga("send","timing",a,b,c):console.warn("Google Analytics has not been loaded");return this};
-Object.defineProperties(Metric.prototype,{duration:{configurable:!0,enumerable:!0,get:function(){var a=_end.get(this)-_start.get(this);if(Metric.supportsPerfMark){var b=performance.getEntriesByName(this.name)[0];b&&"measure"!==b.entryType&&(a=b.duration)}return a||-1}}});Object.defineProperties(Metric,{supportsPerfNow:{configurable:!0,enumerable:!0,get:function(){return self.performance&&performance.now}},supportsPerfMark:{configurable:!0,enumerable:!0,get:function(){return self.performance&&performance.mark}}});
+Object.defineProperties(Metric.prototype,{duration:{configurable:!0,enumerable:!0,get:function(){var a=_end.get(this)-_start.get(this);if(Metric.supportsPerfMark){var b=performance.getEntriesByName(this.name)[0];b&&"measure"!==b.entryType&&(a=b.duration)}return a||-1}}});
+Object.defineProperties(Metric,{supportsPerfNow:{configurable:!0,enumerable:!0,get:function(){return Boolean(self.performance&&performance.now)}},supportsPerfMark:{configurable:!0,enumerable:!0,get:function(){return Boolean(self.performance&&performance.mark)}}});"undefined"!==typeof module&&(module.exports=Metric);

dist/appmetrics.min.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-unused-vars */
-
 /**
  * Copyright 2016 - Eric Bidelman <ebidel@>
  *
@@ -23,11 +21,11 @@
  * API and (optionally) reporting those timings to Google Analytics.
  */
 
-'use strict';
+/* eslint-disable no-console */
 
 // Private members.
-let _start = new WeakMap();
-let _end = new WeakMap();
+const _start = new WeakMap();
+const _end = new WeakMap();
 
 class Metric {
 
@@ -37,7 +35,7 @@ class Metric {
    * @static
    */
   static get supportsPerfNow() {
-    return self.performance && performance.now;
+    return Boolean(self.performance && performance.now);
   }
 
   /**
@@ -46,7 +44,7 @@ class Metric {
    * @static
    */
   static get supportsPerfMark() {
-    return self.performance && performance.mark;
+    return Boolean(self.performance && performance.mark);
   }
 
   /**
@@ -81,27 +79,11 @@ class Metric {
 
     if (!Metric.supportsPerfMark) {
       console.warn(`Timeline won't be marked for "${name}".`);
-
       if (!Metric.supportsPerfNow) {
         throw Error('This library cannot be used in this browser.');
       }
     }
 
-    // if (window.PerformanceObserver) {}
-    //   let observer = new PerformanceObserver(list => {
-    //     list.getEntries().forEach(entry => {
-    //       // Display each reported measurement on console
-    //       if (console) {
-    //         console.log("Name: "       + entry.name      +
-    //                     ", Type: "     + entry.entryType +
-    //                     ", Start: "    + entry.startTime +
-    //                     ", Duration: " + entry.duration  + "\n");
-    //       }
-    //     })
-    //   });
-    //   observer.observe({entryTypes: ['resource', 'mark', 'measure']});
-    // }
-
     this.name = name;
   }
 
@@ -124,9 +106,9 @@ class Metric {
     // Use User Timing API results if available, otherwise return
     // performance.now() fallback.
     if (Metric.supportsPerfNow) {
-      let items = performance.getEntriesByName(name);
+      const items = performance.getEntriesByName(name);
       for (let i = 0; i < items.length; ++i) {
-        let item = items[i];
+        const item = items[i];
         console.info(name, item.duration, 'ms');
       }
     }
@@ -167,8 +149,8 @@ class Metric {
 
     // Support: developer.mozilla.org/en-US/docs/Web/API/Performance/mark
     if (Metric.supportsPerfMark) {
-      let startMark = `mark_${this.name}_start`;
-      let endMark = `mark_${this.name}_end`;
+      const startMark = `mark_${this.name}_start`;
+      const endMark = `mark_${this.name}_end`;
       performance.mark(endMark);
       performance.measure(this.name, startMark, endMark);
     }
@@ -195,3 +177,8 @@ class Metric {
     return this;
   }
 }
+
+if (typeof module !== 'undefined') {
+  module.exports = Metric;
+  // export default Metric;
+}

src/appmetrics.js

@@ -1,32 +1,37 @@
 /* eslint-env node, mocha */
+/* global PerformanceObserver, Metric, chai */
 
 const assert = chai.assert;
 
+/* eslint-disable */
+function loadAnalytics() {
+  (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
+  (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
+  m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m);
+  })(window,document,'script','https://www.google-analytics.com/analytics.js','ga');
+  ga('create', 'UA-XXXXX-Y', 'auto');
+}
+/* eslint-enable */
+
+loadAnalytics();
+
 describe('appmetrics.js', function() {
   const METRIC_NAME = 'test_metric';
-  let metric = new Metric(METRIC_NAME);
-
-  function loadAnalytics() {
-    (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
-    (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
-    m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m);
-    })(window,document,'script','https://www.google-analytics.com/analytics.js','ga');
-    ga('create', 'UA-XXXXX-Y', 'auto');
-  }
+  const metric = new Metric(METRIC_NAME);
 
   function isAnalyticsRequest(entry) {
     return entry.name.includes('/collect') && entry.name.includes('t=timing');
   }
 
   if (!window.PerformanceObserver) {
-    throw 'Cannot run tests in a browser PerformanceObserver';
+    throw Error('Cannot run tests in a browser PerformanceObserver');
   }
 
   before(function() {
     if (!location.origin.includes('localhost')) {
       assert.fail(false, true, 'Tests need to be run from a web server.');
     }
-    loadAnalytics();
+    // loadAnalytics();
   });
 
   beforeEach(function() {
@@ -44,8 +49,8 @@ describe('appmetrics.js', function() {
       assert.equal(metric.duration, -1);
     });
     it('has correct feature detection', function() {
-      assert.equal(Metric.supportsPerfNow, performance.now);
-      assert.equal(Metric.supportsPerfMark, performance.mark);
+      assert.equal(Metric.supportsPerfNow, true);
+      assert.equal(Metric.supportsPerfMark, true);
     });
     it('has private properties', function() {
       assert.isUndefined(metric._start);
@@ -54,12 +59,11 @@ describe('appmetrics.js', function() {
   });
 
   describe('start()', function() {
-
     it('creates a mark', function(done) {
-      let observer = new PerformanceObserver(list => {
+      const observer = new PerformanceObserver(list => {
         observer.disconnect();
 
-        let entries = list.getEntriesByName(`mark_${METRIC_NAME}_start`);
+        const entries = list.getEntriesByName(`mark_${METRIC_NAME}_start`);
         assert.equal(entries[0].entryType, 'mark', 'not a mark entry');
         assert.equal(entries.length, 1);
 
@@ -79,17 +83,15 @@ describe('appmetrics.js', function() {
   });
 
   describe('end()', function() {
-
     it('creates a mark', function(done) {
-
-      let observer = new PerformanceObserver(list => {
+      const observer = new PerformanceObserver(list => {
         observer.disconnect();
 
-        let markEntries = list.getEntriesByName(`mark_${METRIC_NAME}_end`);
+        const markEntries = list.getEntriesByName(`mark_${METRIC_NAME}_end`);
         assert.equal(markEntries.length, 1);
         assert.equal(markEntries[0].entryType, 'mark', 'not a mark entry');
 
-        let measureEntries = list.getEntriesByName(METRIC_NAME);
+        const measureEntries = list.getEntriesByName(METRIC_NAME);
         assert.equal(measureEntries[0].entryType, 'measure', 'not a measurement entry');
         assert.equal(measureEntries.length, 1);
 
@@ -125,12 +127,11 @@ describe('appmetrics.js', function() {
   });
 
   describe('sendToAnalytics()', function() {
-
     it('sends default request', function(done) {
-      let observer = new PerformanceObserver(list => {
+      const observer = new PerformanceObserver(list => {
         observer.disconnect();
 
-        let entries = list.getEntries().filter(entry => {
+        const entries = list.getEntries().filter(entry => {
           return isAnalyticsRequest(entry) &&
                  entry.name.includes(metric.duration) &&
                  entry.name.includes(metric.name) &&
@@ -146,10 +147,10 @@ describe('appmetrics.js', function() {
     });
 
     it('can override duration and name', function(done) {
-      let observer = new PerformanceObserver(list => {
+      const observer = new PerformanceObserver(list => {
         observer.disconnect();
 
-        let entries = list.getEntries().filter(entry => {
+        const entries = list.getEntries().filter(entry => {
           return isAnalyticsRequest(entry) &&
                  entry.name.includes('1234567890') &&
                  entry.name.includes('category_name') &&
@@ -165,12 +166,12 @@ describe('appmetrics.js', function() {
     });
 
     it('can send a duration without measuring', function(done) {
-      let duration = Date.now();
+      const duration = Date.now();
 
-      let observer = new PerformanceObserver(list => {
+      const observer = new PerformanceObserver(list => {
         observer.disconnect();
 
-        let entries = list.getEntries().filter(entry => {
+        const entries = list.getEntries().filter(entry => {
           return isAnalyticsRequest(entry) &&
                  entry.name.includes(duration) &&
                  entry.name.includes('category_name') &&
@@ -182,24 +183,24 @@ describe('appmetrics.js', function() {
       });
       observer.observe({entryTypes: ['resource']});
 
-      let metric = new Metric('override_duration');
+      const metric = new Metric('override_duration');
       metric.sendToAnalytics('category_name', metric.name, duration);
     });
 
     it('no requests are to GA before a measurement', function(done) {
       // If the perf observer sees a request, the test should fail.
-      let observer = new PerformanceObserver(list => {
+      const observer = new PerformanceObserver(list => {
         observer.disconnect();
-        assert.fail(false, true, 'Google Analytics request was sent before a measurement was made.');
+        assert.fail(
+            false, true, 'Google Analytics request was sent before a measurement was made.');
         done();
       });
       observer.observe({entryTypes: ['resource']});
 
-      let metric = new Metric('test_metric');
+      const metric = new Metric('test_metric');
       metric.sendToAnalytics('should_not_be_sent');
 
       setTimeout(done, 500);
     });
   });
-
 });