Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing license declaration for winzone.py #1336

Closed
stefan6419846 opened this issue Oct 22, 2024 · 3 comments · Fixed by #1337
Closed

Missing license declaration for winzone.py #1336

stefan6419846 opened this issue Oct 22, 2024 · 3 comments · Fixed by #1337

Comments

@stefan6419846
Copy link
Contributor

Describe the bug

https://github.com/ecederstrand/exchangelib/blob/master/exchangelib/winzone.py embeds data sourced from an unknown version of https://github.com/unicode-org/cldr/blob/main/common/supplemental/windowsZones.xml Depending on the version, they are subject to either Unicode-DFS-2016 or Unicode-3.0, which both require to at least include the copyright and permission notice with the distribution. As far as it concerns the wheels, this is not the case at the moment, but might affect source distributions as well.

Expected behavior

exchangelib documents which version of the windowsZones.xml is being included and whether changes have been done. Additionally, the copyright and permission notice are shipped within exchangelib accordingly.

Additional context

Disclaimer: IANAL.

@stefan6419846 stefan6419846 changed the title Implement license declaration for winzone.py Missing license declaration for winzone.py Oct 22, 2024
@ecederstrand
Copy link
Owner

The version of CLDR is specified here: CLDR_WINZONE_TYPE_VERSION = "2021a"

https://github.com/unicode-org/cldr/blob/main/common/supplemental/windowsZones.xml only claims copyright until 2013, but in any event it links to http://www.unicode.org/copyright.html which again links to this license for Data Files: https://www.unicode.org/license.txt

I don't see anything in that license that requires exchangelib to make any adjustments. I also don't think that Unicode can claim copyright over Windows timezone names, which is the only thing exchangelib is reproducing in our winzone.py.

@stefan6419846
Copy link
Contributor Author

stefan6419846 commented Oct 22, 2024

The repository has a license and the file itself points to a license file, thus apparently someone considered it copyrightable. IANAL, but at least in Germany, such collections might receive protection due to database rights and require licenses accordingly to declare usage policies.

@ecederstrand
Copy link
Owner

I'm not sure I come to the same conclusion, but I don't mind if you create a PR that adds a link to https://www.unicode.org/license.txt to the top of winzone.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants