[mini.completion] Completefunc or omnifunc?

[abeldekat]

Contributing guidelines

• I have read CODE_OF_CONDUCT.md

Module(s)

mini.completion

Question

I am enjoying mini.completion! Regarding the help, I have some questions/feedback.

The default value of config.lsp_completion.source_func is completefunc. The help mentions the alternative, omnifunc, in this context. Is there a reason to use one or the other? The only difference I see is the key issued to trigger the completion.

The help mentions how to disable snippet support. Unfortunately, for at least lua_ls, the approach is not working.

I think that when comparing with nvim-cmp, the line about signature help is not correct. There is a separate plugin, used here in kickstart. I wonder if it's relevant that nvim-cmp does not allow a fallback action. Is that action needed when you have separate sources for buffer, path and the like?
The plugin does have some distinct features("virtual_text", "performance tweaks", "follow_cursor").

The help mentions that a large delay can be used to disable actions. As completion is spawned often, wouldn't lots of "infinite in progress" timers degrade performance?

[echasnovski]

The default value of config.lsp_completion.source_func is completefunc. The help mentions the alternative, omnifunc, in this context. Is there a reason to use one or the other? The only difference I see is the key issued to trigger the completion.

Generally speaking - not really. The option is there if user wants to use own 'completefunc' or 'omnifunc', so 'mini.completion' is able to use the other. The 'completefunc' is chosen as default because 'omnifunc' is more likely to be used by filetype plugin.

One other different I noticed very recently during addition of info/signature scrolling is that <C-u> is hardcoded if completion is started with 'completefunc' (i.e. <C-x><C-u>). So it is not possible to use <C-u> for scrolling if 'completefunc' is used as source function.

The help mentions how to disable snippet support. Unfortunately, for at least lua_ls, the approach is not working.

Judging by LSP specification and other LSP servers, it should. If you don't want items with Snippet kind to appear as suggestions, they can be filtered out in lsp_completion.process_items.

I think that when comparing with nvim-cmp, the line about signature help is not correct. There is a separate plugin, used here in kickstart.

The point is that it requires a separate plugin and is not a part of 'nvim-cmp'. Probably saying that directly (that it requires a plugin) is better, but that is also a bit meaningless because any extra functionality can (in theory) be added to any plugin.

I wonder if it's relevant that nvim-cmp does not allow a fallback action. Is that action needed when you have separate sources for buffer, path and the like?

The point is that with 'mini.completion' there is a way to perform any action if there is no LSP candidates. Writing custom source that does some side effects while not returning any candidates might be an alternative, but it's just not designed for that. Maybe a better phrasing is needed here.

The plugin does have some distinct features("virtual_text", "performance tweaks", "follow_cursor").

Yes, the whole comparison needs a bit touch up. Both for 'nvim-cmp' and to include 'blink.cmp'.

The help mentions that a large delay can be used to disable actions. As completion is spawned often, wouldn't lots of "infinite in progress" timers degrade performance?

There is a single timer for each action used. There is hardly any performance issues with resetting a timer.

[abeldekat]

Thank you!