Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon not shown for nested URL paths #1916

Open
sschuberth opened this issue Jan 30, 2025 · 5 comments
Open

Favicon not shown for nested URL paths #1916

sschuberth opened this issue Jan 30, 2025 · 5 comments
Labels
ui Issues related to the UI.

Comments

@sschuberth
Copy link
Contributor

It seems that the favicon is now only being displayed for the top-level URL, but not anymore when navigating into an organization / product / repository etc.

Maybe #1763 broke it.

@sschuberth sschuberth added bug ui Issues related to the UI. labels Jan 30, 2025
@Etsija
Copy link
Contributor

Etsija commented Jan 30, 2025

It's not missing from Docker Compose environment, only from our deployment env.

@mnonnenmacher
Copy link
Contributor

For me it works as long as I don't reload the page from a subpage. I guess this is the way to go.

@mnonnenmacher
Copy link
Contributor

I have tried setting the base to ./ as proposed in the link, but it did not work because now it's trying to load the assets relative to the page, so when I load /organizations/1 the paths for the JS and CSS assets would be /organization/1/assets/.... This is not what I expected after reading the docs and I'm lost here.

@mmurto @Etsija @lamppu Any idea how to properly fix this?

@Etsija
Copy link
Contributor

Etsija commented Feb 13, 2025

@mnonnenmacher I'm still trying to reproduce the problem. What's the situation you encounter where the favicon disappears? On Docker Compose, it never disappears for me, it's just always there. Have gone to subpages, then reloaded - it's always visible.

I see, on our deployment environment, it does disappear when reloading a subpage. It puzzles me why it doesn't disappear on compose.

@mnonnenmacher
Copy link
Contributor

It puzzles me why it doesn't disappear on compose.

This is weird, for me it disappears also in Compose when reloading a subpage.

@mnonnenmacher mnonnenmacher removed the bug label Feb 19, 2025
mnonnenmacher added a commit that referenced this issue Feb 26, 2025
This reverts commit 40fe0e1.

The fix only worked when loading the root URL of the UI, not when
loading it from any subpath like `organizations/1`. Revert the change to
make the favicon at least work consistently when the UI is not deployed
to a subpath.

Relates to #1916.
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2025
This reverts commit 40fe0e1.

The fix only worked when loading the root URL of the UI, not when
loading it from any subpath like `organizations/1`. Revert the change to
make the favicon at least work consistently when the UI is not deployed
to a subpath.

Relates to #1916.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Issues related to the UI.
Projects
None yet
Development

No branches or pull requests

3 participants