Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the rule violations endpoint to take resolutions into account #2071

Open
sschuberth opened this issue Feb 20, 2025 · 1 comment
Open
Labels
api Issues related to the API.

Comments

@sschuberth
Copy link
Contributor

Currently, https://eclipse-apoapsis.github.io/ort-server/api/get-rule-violations-by-run-id seems to always return all rule violations, independently whether they have already been resolved, e.g. via an .ort.yml rule violation resolution, or not.

The endpoint should be improved to return also at least a boolean to indicate whether a rule violation has been resolved, to that the could only show unresolved rule violations, or pre-configure a UI filter accordingly.

Maybe some additional information about a rule violation resolution would be nice, like the place where it's configured. So instead of a boolean, there could be a ResolutionType enum saying UNRESOLVED, RESOLVED_BY_REPO_CONFIG, etc.

@sschuberth sschuberth added the api Issues related to the API. label Feb 20, 2025
@sschuberth sschuberth changed the title Improve the rule violations endpoint to take resolved resolutins into account Improve the rule violations endpoint to take resolved resolutions into account Feb 21, 2025
@sschuberth sschuberth changed the title Improve the rule violations endpoint to take resolved resolutions into account Improve the rule violations endpoint to take resolutions into account Feb 21, 2025
@mnonnenmacher
Copy link
Contributor

Maybe some additional information about a rule violation resolution would be nice

IMO it should include the whole resolution so that the rationale can be shown in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues related to the API.
Projects
None yet
Development

No branches or pull requests

2 participants