Skip to content

Commit 1fa7c9f

Browse files
committed
update GitServices list
1 parent 02c74bb commit 1fa7c9f

File tree

2 files changed

+20
-18
lines changed

2 files changed

+20
-18
lines changed

tests/e2e/pageobjects/dashboard/UserPreferences.ts

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,14 @@ import { By } from 'selenium-webdriver';
1414
import { DriverHelper } from '../../utils/DriverHelper';
1515
import { Logger } from '../../utils/Logger';
1616

17-
enum GitService {
18-
github = 'github',
19-
gitlab='gitlab',
20-
'azure-devops'='azure-devops',
21-
'bitbucket-server-oauth1'='bitbucket-server-oauth1',
22-
'bitbucket-server-oauth2'='bitbucket-server-oauth2'
23-
}
17+
enum GitServices {
18+
GITHUB = 'github',
19+
GITLAB = 'gitlab',
20+
BITBUCKET_SERVER_OAUTH1 = 'bitbucket-server-oauth1',
21+
BITBUCKET_SERVER_OAUTH2 = 'bitbucket-server-oauth2',
22+
BITBUCKET_CLOUD_OAUTH2 = 'bitbucket-org',
23+
AZURE_DEVOPS = 'azure-devops'
24+
}
2425

2526
@injectable()
2627
export class UserPreferences {
@@ -119,15 +120,16 @@ export class UserPreferences {
119120
await this.driverHelper.waitVisibility(UserPreferences.ADD_NEW_SSH_KEY_BUTTON);
120121
}
121122

122-
async getServiceConfig(service: string): Promise<string> {
123-
const gitService: { [key: string]: string } = {
124-
[GitService.github]: 'GitHub',
125-
[GitService.gitlab]: 'GitLab',
126-
[GitService['azure-devops']]: 'Microsoft Azure DevOps',
127-
[GitService['bitbucket-server-oauth1']]: 'Bitbucket Server',
128-
[GitService['bitbucket-server-oauth2']]: 'Bitbucket Server'
123+
getServiceConfig(service: string): string {
124+
const gitService: { [key: string]: string } = {
125+
[GitServices.GITHUB]: 'GitHub',
126+
[GitServices.GITLAB]: 'GitLab',
127+
[GitServices.AZURE_DEVOPS]: 'Microsoft Azure DevOps',
128+
[GitServices.BITBUCKET_CLOUD_OAUTH2]: 'Bitbucket Cloud',
129+
[GitServices.BITBUCKET_SERVER_OAUTH1]: 'Bitbucket Server',
130+
[GitServices.BITBUCKET_SERVER_OAUTH2]: 'Bitbucket Server'
129131
};
130-
132+
131133
return gitService[service];
132134
}
133135

tests/e2e/specs/miscellaneous/RevokeOauth.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { LoginTests } from '../../tests-library/LoginTests';
1313
import { UserPreferences } from '../../pageobjects/dashboard/UserPreferences';
1414
import { FACTORY_TEST_CONSTANTS } from '../../constants/FACTORY_TEST_CONSTANTS';
1515

16-
suite(`"Revoke OAuth" test`, function (): void {
16+
suite('"Revoke OAuth" test', function (): void {
1717
const loginTests: LoginTests = e2eContainer.get(CLASSES.LoginTests);
1818
const userPreferences: UserPreferences = e2eContainer.get(CLASSES.UserPreferences);
1919
const gitService: string = FACTORY_TEST_CONSTANTS.TS_SELENIUM_FACTORY_GIT_PROVIDER || 'github';
@@ -27,8 +27,8 @@ suite(`"Revoke OAuth" test`, function (): void {
2727
await userPreferences.checkTabsAvailability();
2828

2929
await userPreferences.openGitServicesTab();
30-
31-
const selectedService: string = await userPreferences.getServiceConfig(gitService);
30+
31+
const selectedService: string = userPreferences.getServiceConfig(gitService);
3232
await userPreferences.revokeGitService(selectedService);
3333
});
3434
});

0 commit comments

Comments
 (0)