Add storage type attribute to DevWorkspace configuration in API tests; fix EmptyWorkspace PR check (#23455)

* Add storage type attribute to DevWorkspace configuration in API tests

* Get running devspaces-dashboard pod only

* Enhance cleanup process in PR check workflow to free up disk space

* Don't remove unused Docker images and containers

* Set TS_SELENIUM_START_WORKSPACE_TIMEOUT=300 secs

* Set MOCHA_DEFAULT_TIMEOUT=420000

Author: dmytro-ndp

.github/workflows/pr-check.yml

@@ -120,12 +120,35 @@ jobs:
             rm -rf assembly
             docker build -t quay.io/eclipse/che-e2e:"${{ env.pr_number }}" -f build/dockerfiles/Dockerfile .
 
-        # we have already ran API test, built test image and do not need e2e test-code, remove for saving disk space
-      - name: Clean up resources
+      - name: Clean up to save disk space
         run: |
-           ls -la ${GITHUB_WORKSPACE}
-           rm -rf ${GITHUB_WORKSPACE}/che
-           docker images
+          echo "Available space before cleanup:"
+          df -h
+
+          # Clean up unused npm artifacts
+          rm -rf node_modules
+          npm cache clean --force
+
+          # Remove large packages
+          sudo apt-get remove -y '^aspnetcore-.*' '^dotnet-.*' '^llvm-.*' '^php.*'
+          sudo apt-get remove -y azure-cli google-chrome-stable firefox powershell mono-devel
+          sudo apt-get autoremove -y
+          sudo apt-get autoclean
+          
+          # Remove large directories
+          sudo rm -rf /usr/local/lib/android
+          sudo rm -rf /usr/share/dotnet
+          sudo rm -rf /opt/ghc
+          sudo rm -rf /opt/hostedtoolcache/CodeQL
+          
+          # we have already ran API test, built test image and do not need e2e test-code
+          ls -la ${GITHUB_WORKSPACE}
+          rm -rf ${GITHUB_WORKSPACE}/che
+
+          echo "Available space after cleanup:"
+          df -h
+          docker container ls
+          docker images
 
       - name: Run Empty Workspace UI test from che-e2e container
         run: |
@@ -140,7 +163,8 @@ jobs:
             -e TS_SELENIUM_VALUE_OPENSHIFT_OAUTH=false \
             -e TS_SELENIUM_BASE_URL=https://$(kubectl get ingress che -n eclipse-che -o jsonpath='{.spec.rules[0].host}') \
             -e TS_SELENIUM_LOAD_PAGE_TIMEOUT=60000 \
-            -e TS_SELENIUM_START_WORKSPACE_TIMEOUT=120000 \
+            -e TS_SELENIUM_START_WORKSPACE_TIMEOUT=300000 \
+            -e MOCHA_DEFAULT_TIMEOUT=420000 \
             -e TS_COMMON_DASHBOARD_WAIT_TIMEOUT=30000 \
             -e NODE_TLS_REJECT_UNAUTHORIZED=0 \
             -e DELETE_WORKSPACE_ON_FAILED_TEST=true \

tests/e2e/constants/API_TEST_CONSTANTS.ts

@@ -35,6 +35,7 @@ export const API_TEST_CONSTANTS: {
 	TS_API_TEST_UDI_IMAGE: string | undefined;
 	TS_API_TEST_NAMESPACE: string | undefined;
 	TS_API_ACCEPTANCE_TEST_REGISTRY_URL(): string;
+	TS_API_TEST_STORAGE_TYPE: string;
 } = {
 	/**
 	 * possible values "oc" or "kubectl"
@@ -71,5 +72,7 @@ export const API_TEST_CONSTANTS: {
 		return process.env.TS_API_ACCEPTANCE_TEST_REGISTRY_URL || '';
 	},
 
-	TS_API_TEST_DEV_WORKSPACE_LIST: process.env.TS_API_TEST_DEV_WORKSPACE_LIST || undefined
+	TS_API_TEST_DEV_WORKSPACE_LIST: process.env.TS_API_TEST_DEV_WORKSPACE_LIST || undefined,
+
+	TS_API_TEST_STORAGE_TYPE: process.env.TS_API_TEST_STORAGE_TYPE || 'per-user'
 };

tests/e2e/utils/DevWorkspaceConfigurationHelper.ts

@@ -60,13 +60,18 @@ export class DevWorkspaceConfigurationHelper {
 		if (!this.params.projects) {
 			this.params.projects = [];
 		}
-		return await this.generator.generateDevfileContext(
+
+		const devfileContext: DevfileContext = await this.generator.generateDevfileContext(
 			{
 				...this.params,
 				projects: this.params.projects
 			},
 			axios.default as any
 		);
+
+		this.patchDevWorkspaceConfigWithStorageTypeAttribute(devfileContext);
+
+		return devfileContext;
 	}
 
 	// write templates and then DevWorkspace in a single file
@@ -108,4 +113,17 @@ export class DevWorkspaceConfigurationHelper {
                     controller.devfile.io/scc: container-build
                     controller.devfile.io/storage-type: per-user`);
 	}
+
+	/**
+	 * add storage type attribute to fix issue CRW-8922.
+	 */
+	patchDevWorkspaceConfigWithStorageTypeAttribute(
+		devfileContextDevWorkspace: DevfileContext,
+		storageType: string = API_TEST_CONSTANTS.TS_API_TEST_STORAGE_TYPE
+	): void {
+		Logger.debug();
+		devfileContextDevWorkspace.devWorkspace?.spec?.template &&
+			(devfileContextDevWorkspace.devWorkspace.spec.template.attributes = YAML.parse(`
+					controller.devfile.io/storage-type: ${storageType}`));
+	}
 }

tests/e2e/utils/DevfilesHelper.ts

@@ -62,7 +62,7 @@ export class DevfilesHelper {
 		console.log(`command: ${command}`);
 		const podName: string = this.getShellExecutor()
 			.executeArbitraryShellScript(
-				`oc get pods -n ${BASE_TEST_CONSTANTS.TS_PLATFORM}-${BASE_TEST_CONSTANTS.TESTING_APPLICATION_NAME()} | grep dashboard | awk \'{print $1}\'`
+				`oc get pods -n ${BASE_TEST_CONSTANTS.TS_PLATFORM}-${BASE_TEST_CONSTANTS.TESTING_APPLICATION_NAME()} --field-selector status.phase=Running | grep dashboard | awk \'{print $1}\'`
 			)
 			.trim();
 		const containerName: string = this.getShellExecutor().executeArbitraryShellScript(