Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonarqube Fixes #1603

Closed
gorky opened this issue Feb 10, 2022 · 2 comments
Closed

Sonarqube Fixes #1603

gorky opened this issue Feb 10, 2022 · 2 comments

Comments

@gorky
Copy link
Contributor

gorky commented Feb 10, 2022

I ran this project through Sonarqube and it found a bunch of issues. I have an automated solution for fixing issues. As handling is added for fixing issues, I will submit the patches under this ticket.

If anyone would like access to the Sonarqube server with the scan results, please DM me and I will set you up.
sanddusttx added a commit to j2eeguys/jaxb-ri that referenced this issue Feb 13, 2022
@sanddusttx
Sonarqube Fixes
f513608 
eclipse-ee4j#1603
xsom/src/main/java/com/sun/xml/xsom/XSSchema.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
jxc/src/main/java/com/sun/tools/jxc/ConfigReader.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/runtime/reflect/Lister.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
xsom/src/main/java/com/sun/xml/xsom/impl/scd/SimpleCharStream.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
core/src/main/java/org/glassfish/jaxb/core/marshaller/Messages.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xsom/src/main/java/com/sun/xml/xsom/impl/parser/SAXParserFactoryAdaptor.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
core/src/main/java/org/glassfish/jaxb/core/unmarshaller/DOMScanner.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
codemodel/codemodel/src/main/java/com/sun/codemodel/JAnnotationArrayMember.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/runtime/Coordinator.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]

Signed-off-by: Sanddust <[email protected]>
Also-by: Stephen Davidson <[email protected]>
gorky added a commit to j2eeguys/jaxb-ri that referenced this issue Feb 13, 2022
@gorky
Sonarqube Fixes
9a813ed 
eclipse-ee4j#1603
Updated copyrights in modified files.

Signed-off-by: Stephen Davidson <[email protected]>
@gorky gorky mentioned this issue Feb 13, 2022
Merged
gorky pushed a commit to j2eeguys/jaxb-ri that referenced this issue Feb 17, 2022
@sanddusttx @gorky
Sonarqube Fixes
2e000ce 
eclipse-ee4j#1603
xsom/src/main/java/com/sun/xml/xsom/XSSchema.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
jxc/src/main/java/com/sun/tools/jxc/ConfigReader.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/runtime/reflect/Lister.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
xsom/src/main/java/com/sun/xml/xsom/impl/scd/SimpleCharStream.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
core/src/main/java/org/glassfish/jaxb/core/marshaller/Messages.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xsom/src/main/java/com/sun/xml/xsom/impl/parser/SAXParserFactoryAdaptor.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
core/src/main/java/org/glassfish/jaxb/core/unmarshaller/DOMScanner.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
codemodel/codemodel/src/main/java/com/sun/codemodel/JAnnotationArrayMember.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/runtime/Coordinator.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]

Signed-off-by: Sanddust <[email protected]>
Also-by: Stephen Davidson <[email protected]>
gorky added a commit to j2eeguys/jaxb-ri that referenced this issue Feb 17, 2022
@gorky
Sonarqube Fixes
2d8f114 
eclipse-ee4j#1603
Updated copyrights in modified files.

Signed-off-by: Stephen Davidson <[email protected]>
gorky added a commit to j2eeguys/jaxb-ri that referenced this issue Feb 17, 2022
@gorky
Sonarqube Fixes eclipse-ee4j#1603
44dbf46 
eclipse-ee4j#1603
Fixed version in @deprecated annotations.

Signed-off-by: Steve Davidson <[email protected]>
@gorky
Copy link
Contributor Author

gorky commented Feb 17, 2022

There will be additional updates as the Honor Systems Updater is enhanced to handle more issues and scenarios. As a result, I would suggest keeping this ticket open there will be additional commits under this topic.

@lukasj lukasj closed this as completed in 54dbf64 Mar 16, 2022
lukasj pushed a commit that referenced this issue Mar 16, 2022
@gorky @lukasj
Sonarqube Fixes
d3a3705 
#1603
Updated copyrights in modified files.

Signed-off-by: Stephen Davidson <[email protected]>
lukasj pushed a commit that referenced this issue Mar 16, 2022
@gorky @lukasj
Sonarqube Fixes #1603
934c5b9 
#1603
Fixed version in @deprecated annotations.

Signed-off-by: Steve Davidson <[email protected]>
hsujenkins added a commit to j2eeguys/jaxb-ri that referenced this issue Jun 20, 2022
@hsujenkins
Honor Systems generated updates
146888f 
eclipse-ee4j#1603
Automatic updates
https://jenkins.updater.j2eeguys.com/
txw/runtime/src/main/java/com/sun/xml/txw2/output/IndentingXMLFilter.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
codemodel/codemodel/src/main/java/com/sun/codemodel/JCodeModel.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/model/impl/EnumLeafInfoImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/model/nav/NavigatorImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/runtime/XMLSerializer.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
codemodel/codemodel/src/main/java/com/sun/codemodel/JClassContainer.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/model/Model.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/api/SchemaCompiler.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xsom/src/main/java/com/sun/xml/xsom/XSDeclaration.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
codemodel/codemodel/src/main/java/com/sun/codemodel/JDefinedClass.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/model/impl/ElementInfoImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/model/CElementInfo.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/model/CBuiltinLeafInfo.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
external/rngom/src/main/java/com/sun/tools/rngom/ast/builder/IncludedGrammar.java
    Remove this unused import 'com.sun.tools.rngom.parse.Parseable'. [java:S1128]
xsom/src/main/java/com/sun/xml/xsom/impl/ElementDecl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
external/rngom/src/main/java/com/sun/tools/rngom/parse/compact/UCode_UCodeESC_CharStream.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/model/CClassInfo.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
txw/runtime/src/main/java/com/sun/xml/txw2/output/IndentingXMLStreamWriter.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
core/src/main/java/org/glassfish/jaxb/core/marshaller/DataWriter.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/model/CEnumLeafInfo.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/api/JAXBModel.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/model/impl/ClassInfoImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
core/src/main/java/org/glassfish/jaxb/core/annotation/XmlIsSet.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
codemodel/codemodel/src/main/java/com/sun/codemodel/JPrimitiveType.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xsom/src/main/java/com/sun/xml/xsom/impl/parser/SAXParserFactoryAdaptor.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xsom/src/main/java/com/sun/xml/xsom/impl/ParticleImpl.java
    Remove this unused import 'com.sun.xml.xsom.ForeignAttributes'. [java:S1128]
xjc/src/main/java/com/sun/tools/xjc/model/AbstractCTypeInfoImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/model/impl/LeafInfoImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/model/impl/ArrayInfoImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/model/impl/BuiltinLeafInfoImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/runtime/unmarshaller/UnmarshallerImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
codemodel/codemodel/src/main/java/com/sun/codemodel/JPackage.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/reader/gbind/Element.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/model/CPropertyInfo.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/model/impl/AnyTypeImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
codemodel/codemodel/src/main/java/com/sun/codemodel/JAnnotationUse.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
core/src/main/java/org/glassfish/jaxb/core/marshaller/SAX2DOMEx.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
txw/runtime/src/main/java/com/sun/xml/txw2/output/DataWriter.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/DatatypeConverterImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xjc/src/main/java/com/sun/tools/xjc/XJCBase.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
external/relaxng-datatype/src/main/java/com/sun/tools/rngdatatype/helpers/DatatypeLibraryLoader.java
    Remove this unused import 'java.io.UnsupportedEncodingException'. [java:S1128]
codemodel/codemodel-annotation-compiler/src/main/java/com/sun/codemodel/ac/ACTask.java
    Remove this unused import 'java.net.MalformedURLException'. [java:S1128]
    Remove this unused import 'java.net.URL'. [java:S1128]
xsom/src/main/java/com/sun/xml/xsom/impl/DeclarationImpl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
runtime/impl/src/main/java/org/glassfish/jaxb/runtime/v2/ContextFactory.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
xsom/src/main/java/com/sun/xml/xsom/XSElementDecl.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]
external/rngom/src/main/java/com/sun/tools/rngom/parse/compact/JavaCharStream.java
    Add 'since' and/or 'forRemoval' arguments to the @deprecated annotation. [squid:MissingDeprecatedCheck]

Also-by: Stephen Davidson <[email protected]>
Signed-off-by: Honor Systems Updater Jenkins <[email protected]>
@gorky gorky mentioned this issue Jun 20, 2022
Open
@gorky
Copy link
Contributor Author

gorky commented Jun 20, 2022 •
edited
Loading

Opened #1651 as it seems that this ticket can not be re-opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gorky