Regression: yasson on SpringBoot: IOException Stream Closed

[IndyNaessens]

Describe the bug
It seems there is a regression on the following issue #389. I originally reported the issue here spring-projects/spring-boot#35651.

To Reproduce

FileWriter writer = new FileWriter("output.json");
Jsonb jsonb = JsonbBuilder.create();
jsonb.toJson(Collections.singletonMap("a", "alpha"), writer);
jsonb.toJson(Collections.singletonMap("a", "alpha"), writer);

Expected behavior
toJson not closing the writer.

System information:

• OS: Windows
• Java Version: 17
• Yasson Version: 3.0.3

Additional context
This issue seems to be introduced with version 3.0.3. Version 3.0.2 and below work as expected.

[Degubi]

Seems to be caused by #586, reverting this fixes it for me

[jamezp]

#586 is the correct fix according the Jsonb.fromJson() JavaDoc.

stream - The stream is read as a JSON data. Upon a successful completion, the stream will be closed by this method.

[greek1979]

Discovered few days ago in our test system that REST/JSON based backend app logs are literally FULL of the very same error. The output stream being already closed by the moment Spring's JSON HTTP message converter attempts to write the response and flush it to the (http) output stream. After some code analysis, I reached the same offending change (#586 ) that someone introduced into Yasson 3.0.3 to supposedly auto-close the generators and parsers...

Well, it ruins the intent of original fix (#389 ) as can be clearly evident from org.eclipse.yasson.internal.JsonBinding code:

@Override
public String toJson(Object object, Type type) throws JsonbException {
    StringWriter writer = new StringWriter();
    try (JsonGenerator generator = writerGenerator(writer)) {
        new SerializationContextImpl(jsonbContext, type).marshall(object, generator);
    }
    return writer.toString();
}

@Override
public void toJson(Object object, Writer writer) throws JsonbException {
    final SerializationContextImpl marshaller = new SerializationContextImpl(jsonbContext);
    try (JsonGenerator generator = writerGenerator(writer)) {
        marshaller.marshallWithoutClose(object, generator);
    }
}

The try-with-resources obviously closes the JSON generator once the "marshall-WITHOUT-close" (emphasis mine) method completes. Why close the resource if the intent is NOT to close it?... Sorry for the rant.

System information:

• OS: Windows 11
• Java Version: 17
• Yasson Version: 3.0.4 (latest one as of writing)
• Spring Version: 5.3.39 (not Spring Boot)

[greek1979]

The #631 did resolve the implicitly closing the output STREAMS when generating JSON content, but my particular issue is with (output) WRITERS, not streams. They should not be closed by Yasson code either if a ready-to-use Writer has been passed in by the calling code; the calling code is supposed to take care of its resources and objects.

[greek1979]

I believe this issue can now be safely closed as it has been essentially duplicated by #662 and the latter has been reviewed, approved, merged and closed.