Test Results

  663 files  + 3    663 suites  +3   1h 17m 11s ⏱️ -53s
2 209 tests + 8  2 162 ✅ + 8   47 💤 ±0  0 ❌ ±0 
6 771 runs  +24  6 628 ✅ +24  143 💤 ±0  0 ❌ ±0 

Results for commit daa4169. ± Comparison against base commit 2815608.

AutomatedTests org.eclipse.osgi.tests.bundles.BundleTests org.eclipse.osgi.tests.bundles.ExceptionMessageTest ‑ testUninstallContextError
AutomatedTests org.eclipse.osgi.tests.bundles.BundleTests org.eclipse.osgi.tests.bundles.ExceptionMessageTest ‑ testUnregisterTwiceError

AutomatedTests org.eclipse.osgi.tests.bundles.BundleTests org.eclipse.osgi.tests.bundles.IllegalStateExceptionTests ‑ testContextUngetService
AutomatedTests org.eclipse.osgi.tests.bundles.BundleTests org.eclipse.osgi.tests.bundles.IllegalStateExceptionTests ‑ testCreateFilter
AutomatedTests org.eclipse.osgi.tests.bundles.BundleTests org.eclipse.osgi.tests.bundles.IllegalStateExceptionTests ‑ testFrameworkListener
AutomatedTests org.eclipse.osgi.tests.bundles.BundleTests org.eclipse.osgi.tests.bundles.IllegalStateExceptionTests ‑ testGetBundle
AutomatedTests org.eclipse.osgi.tests.bundles.BundleTests org.eclipse.osgi.tests.bundles.IllegalStateExceptionTests ‑ testGetProperty
AutomatedTests org.eclipse.osgi.tests.bundles.BundleTests org.eclipse.osgi.tests.bundles.IllegalStateExceptionTests ‑ testRemoveBundleListener
AutomatedTests org.eclipse.osgi.tests.bundles.BundleTests org.eclipse.osgi.tests.bundles.IllegalStateExceptionTests ‑ testRemoveServiceListener
AutomatedTests org.eclipse.osgi.tests.bundles.BundleTests org.eclipse.osgi.tests.bundles.IllegalStateExceptionTests ‑ testServiceObjectsUngetService
AutomatedTests org.eclipse.osgi.tests.bundles.BundleTests org.eclipse.osgi.tests.bundles.IllegalStateExceptionTests ‑ testUninstall
AutomatedTests org.eclipse.osgi.tests.bundles.BundleTests org.eclipse.osgi.tests.bundles.IllegalStateExceptionTests ‑ testUnregister

♻️ This comment has been updated with latest results.

If I merge this it will cause a permanent hard failure in one of the Framework TCK tests. That is fixed in osgi/osgi#787 but we likely will not see a TCK release for some time.

@laeubi is there any way to ignore that failure somehow?

I do not plan to merge this until development of 2025-03 opens up.

@tjwatson Not sure how you run the TCK tests but you can configure Maven surfire to ignore certain tests:

<build>
    <plugins>
        <plugin>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-surefire-plugin</artifactId>
            <version>3.0.0-M7</version>
            <configuration>
                <excludes>
                    <exclude>**/MyFailingTest.java</exclude>
                </excludes>
            </configuration>
        </plugin>
    </plugins>
</build>

See https://maven.apache.org/surefire/maven-surefire-plugin/examples/inclusion-exclusion.html

One thin I can think about would be using the SNAPSHOT of the OSGi repo once it is fixed there.

@tjwatson Not sure how you run the TCK tests but you can configure Maven surfire to ignore certain tests:

<build>
    <plugins>
        <plugin>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-surefire-plugin</artifactId>
            <version>3.0.0-M7</version>
            <configuration>
                <excludes>
                    <exclude>**/MyFailingTest.java</exclude>
                </excludes>
            </configuration>
        </plugin>
    </plugins>
</build>

See https://maven.apache.org/surefire/maven-surefire-plugin/examples/inclusion-exclusion.html

Thanks, I can do that locally, I was wanting to ignore it for the PR validation runs. I will see if something like this can be done.

The TCK is not using usual surefire but https://tycho.eclipseprojects.io/doc/latest/tycho-surefire-plugin/bnd-test-mojo.html

The TCK is not using usual surefire but https://tycho.eclipseprojects.io/doc/latest/tycho-surefire-plugin/bnd-test-mojo.html

If I understand that correctly, it appears I can use <exclude/> to exclude complete test classes, but not single test methods? I would not want to exclude all the tests in https://github.com/osgi/osgi/blob/main/org.osgi.test.cases.framework/src/org/osgi/test/cases/framework/junit/service/ServiceRegistryTests.java

We "only" call the bnd-test here so if there is an option to skip one test you can do it here

as far as I know last time I checked it was not that fine grained but might have changed (or can be improved) at bnd-lib.