Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tests that expect jmod files to be part of all JDKs #3549

Closed
jarthana opened this issue Jan 10, 2025 · 0 comments · Fixed by #3587
Closed

Adjust tests that expect jmod files to be part of all JDKs #3549

jarthana opened this issue Jan 10, 2025 · 0 comments · Fixed by #3587
Assignees

Comments

@jarthana
Copy link
Member

          > > @jarthana Java9ElementTests.test515342b (and possibly others) explicitly tries to read _jdk_/jmods/java.base.jmod, but the temurin JDK used during production builds does not have any jmods.

https://bugs.eclipse.org/bugs/show_bug.cgi?id=515342 doesn't mention jmods, so do you by any chance remember (after more than 7 years ...) why the test was written like this?

This may have been some leftover from the effort of bug 490103 that tried to get rid of the bogus jrt-fs.jar that represents the JRE container. But in the end, we decided it depended too much on the implementation details of the JDK.

Trying to refresh memory of old discussions I came across https://bugs.eclipse.org/bugs/show_bug.cgi?id=490103#c65

Do you think we should remove the implementation for jmod support or only disable / remove those tests?

Originally posted by @stephan-herrmann in #3228 (comment)

@jarthana jarthana self-assigned this Jan 10, 2025
@jarthana jarthana changed the title Remove code added for jmod support Adjust tests that expect jmod files to be part of all JDKs Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant