-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRIU adds jdk.crac APIs #18627
CRIU adds jdk.crac APIs #18627
Conversation
@tajila Could you please review this draft PR? |
jcl/src/java.base/share/classes/jdk/crac/CheckpointException.java
Outdated
Show resolved
Hide resolved
87bba9b
to
5dfa4a0
Compare
Was interrupted by another item and the vacation. @tajila this is ready for another look. |
jcl/src/java.base/share/classes/jdk/crac/CheckpointException.java
Outdated
Show resolved
Hide resolved
5dfa4a0
to
92dd545
Compare
d54b03e
to
6d06eb6
Compare
6d06eb6
to
a119595
Compare
a119595
to
d251f39
Compare
d251f39
to
c7dff2e
Compare
c7dff2e
to
b8074bf
Compare
jcl/src/openj9.criu/share/classes/org/eclipse/openj9/criu/CRIUSupport.java
Outdated
Show resolved
Hide resolved
b8074bf
to
fa6446c
Compare
jcl/src/openj9.criu/share/classes/org/eclipse/openj9/criu/CRIUSupport.java
Outdated
Show resolved
Hide resolved
fa6446c
to
aed2cd4
Compare
@dsouzai Please review JIT changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JIT changes lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
Added jdk.crac.CheckpointException/RestoreException; Added jdk.crac.Context/Resource; Added jdk.crac.Core; Added a new flag J9VM_CRAC_IS_CHECKPOINT_ENABLED; Added a test with a new feature CRAC. Co-authored with Tobi Ajila <[email protected]> Signed-off-by: Jason Feng <[email protected]>
aed2cd4
to
ed1029b
Compare
jenkins test sanity plinux jdk21 |
jenkins test sanity win jdk8 |
jcl/src/java.base/share/classes/openj9/internal/criu/InternalCRIUSupport.java
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/criu/InternalCRIUSupport.java
Show resolved
Hide resolved
I think the build failure in https://openj9-jenkins.osuosl.org/job/Test_openjdknext_j9_sanity.functional_x86-64_linux_Personal_testList_0/33/console is due to this change. |
As we discussed offline, the PR build seems to only have the test part of this change. |
CRIU adds
jdk.crac
APIsAdded
jdk.crac.CheckpointException/RestoreException
;Added
jdk.crac.Context/Resource
;Added
jdk.crac.Core
;Added a new flag
J9VM_CRAC_IS_CHECKPOINT_ENABLED
;Added a test with a new feature
CRAC
.Co-authored with Tobi Ajila [email protected]
Signed-off-by: Jason Feng [email protected]