Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testJITServer - There are no deserialized methods at the client #18691

Open
pshipton opened this issue Jan 4, 2024 · 8 comments
Open

testJITServer - There are no deserialized methods at the client #18691

pshipton opened this issue Jan 4, 2024 · 8 comments
Labels
blocker comp:jitserver Artifacts related to JIT-as-a-Service project test failure

Comments

@pshipton
Copy link
Member

pshipton commented Jan 4, 2024

https://openj9-jenkins.osuosl.org/job/Test_openjdk8_j9_sanity.functional_s390x_linux_Nightly_testList_1/701/
testJITServer_2 -Xcompressedrefs -Xjit -Xgcpolicy:gencon -Xshareclasses:name=test_jitscc -XX:+JITServerUseAOTCache

java.lang.AssertionError: There are no deserialized methods at the client.
	at org.testng.AssertJUnit.fail(AssertJUnit.java:59)
	at jit.test.jitserver.JITServerTest.testServerAOTCache(JITServerTest.java:666)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
@pshipton pshipton added test failure comp:jitserver Artifacts related to JIT-as-a-Service project labels Jan 4, 2024
@pshipton
Copy link
Member Author

pshipton commented Jan 4, 2024

@mpirvu

@pshipton
Copy link
Member Author

https://openj9-jenkins.osuosl.org/job/Test_openjdk21_j9_sanity.functional_s390x_linux_Nightly_testList_1/147/
testJITServer_2
-Xcompressedrefs -Xjit -Xgcpolicy:gencon -Xshareclasses:name=test_jitscc -XX:+JITServerUseAOTCache

FAILED: testServerAOTCache
java.lang.AssertionError: There are no deserialized methods at the client.
	at org.testng.AssertJUnit.fail(AssertJUnit.java:59)
	at jit.test.jitserver.JITServerTest.testServerAOTCache(JITServerTest.java:666)

@mpirvu
Copy link
Contributor

mpirvu commented Jan 24, 2024

It's very likely that this problem is caused by #18656 and will be fixed by #18792
#18656 may cause a server using the AOTCache feature to crash while sitting idle without any client connected to it. If the server dies, it's expected that there will be no deserialized method at the client.

@cjjdespres
Copy link
Contributor

In the testServerAOTCache test we first check the client log for deserialized methods and only if that succeeds do we destroy and check the server process. Maybe we could switch the order in which that happens to confirm that it's the server crashing that is the problem?

@mpirvu
Copy link
Contributor

mpirvu commented Jan 27, 2024

The order may not matter, but we should definitely check that the server hasn't crashed yet.

@pshipton
Copy link
Member Author

testJITServer_2 failed 100% in an OMR acceptance build specific to alinux, zlinux.
https://openj9-jenkins.osuosl.org/job/Pipeline-OMR-Acceptance/639/

This wasn't the case in the Friday night builds.

It seems something in 14ba228...00a123d is causing 100% failure.

@pshipton
Copy link
Member Author

Since the failure was seen in the PR build for #18821 (comment), the failure must be caused by the only other change.

#18827

@mpirvu
Copy link
Contributor

mpirvu commented Jan 29, 2024

@cjjdespres determined that #18821 causes the deserialization at the client to fail consistently.
#18843 will revert that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker comp:jitserver Artifacts related to JIT-as-a-Service project test failure
Projects
Status: To do
Development

No branches or pull requests

3 participants