-
Notifications
You must be signed in to change notification settings - Fork 764
Handle decompile paths when mounting a vthread #22191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jenkins test sanity amac jdk24 |
jenkins test sanity xlinux jdk24 |
Failure in https://openj9-jenkins.osuosl.org/job/Test_openjdk24_j9_sanity.openjdk_x86-64_linux_Personal/13/ is a known issue |
jenkins test sanity amac jdk24 |
jenkins test sanity amac jdk24 |
I think this may be too specific - there could be reasons for decompile other than a decompile all. |
I'm wondering if we could check the decompile stack on remount instead of using the flag. This would also handle the case of a decompile being added and removed before the continuation is remounted. If the top of the decompile stack points to the resolve frame PC, then we are returning to a decompile. |
74fe811
to
095d605
Compare
@gacholio changes ready for another look |
21a71ef
to
e19a89f
Compare
When decompileing a blocked continuation, the return address will be patched to point to the decompile helper when we attempt to enter the continuation. This helper assumes the JIT resolve frame is still on the stack. Instead of popping the resolve frame just jump to the return address and leave the frame in place. The decompile helper will pop the frame. Signed-off-by: tajila <[email protected]>
jenkins test sanity amac jdk24 |
@tajila I think this is ready to go. |
When decompileing a blocked continuation, the return address will be patched to point to the decompile helper when we attempt to enter the continuation. This helper assumes the JIT resolve frame is still on the stack. Instead of popping the resolve frame just fetch the new address and leave the frame in place. The decompile helper will pop the frame.