Skip to content

Fix JNI return types #22199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

Fix JNI return types #22199

merged 1 commit into from
Jul 10, 2025

Conversation

JasonFengJ9
Copy link
Member

Fix JNI return types

CallVoidMethod() replaced CallObjectMethod() for following JNI calls:

Module.implAddExportsOrOpens(Ljava/lang/String;Ljava/lang/Module;ZZ)V;
Module.implAddUses(Ljava/lang/Class;)V;
Thread.interrupt()V;

closes #22000

Signed-off-by: Jason Feng [email protected]

CallVoidMethod() replaced CallObjectMethod() for following JNI calls:
Module.implAddExportsOrOpens(Ljava/lang/String;Ljava/lang/Module;ZZ)V;
Module.implAddUses(Ljava/lang/Class;)V;
Thread.interrupt()V;

Signed-off-by: Jason Feng <[email protected]>
@JasonFengJ9 JasonFengJ9 requested a review from tajila July 9, 2025 13:02
@tajila
Copy link
Contributor

tajila commented Jul 9, 2025

can you add -Xcheck:jni as a mode to some of our modularity and jni tests?

@JasonFengJ9
Copy link
Member Author

can you add -Xcheck:jni as a mode to some of our modularity and jni tests?

Modularity & JNI functionalities are used extensively by different tests, but there aren't much dedicated modularity and jni tests.
I am proposing to add -Xcheck:jni for the test mode 100 at

@tajila
Copy link
Contributor

tajila commented Jul 9, 2025

jenkins test sanity alinux64 jdk17

@tajila tajila merged commit 52244ba into eclipse-openj9:master Jul 10, 2025
6 checks passed
@JasonFengJ9 JasonFengJ9 deleted the jnicalls branch July 10, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-Xcheck:jni detects an error in jvmtiAddModuleReads
2 participants