Skip to content

Support using newer versions of cmake #22202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

keithc-ca
Copy link
Contributor

Newer builds of cmake may not be compatible with version 3.5.

This is essentially a replay of #22161, but with a fix for AIX to remove -qsourcetype=assembler which doesn't appear to work with OpenXL.

@keithc-ca keithc-ca requested a review from pshipton July 9, 2025 19:15
Newer builds of cmake may not be compatible with version 3.5.

Remove -qsourcetype=assembler which doesn't appear to work with OpenXL.

Signed-off-by: Keith W. Campbell <[email protected]>
@pshipton pshipton merged commit 672797d into eclipse-openj9:master Jul 9, 2025
2 checks passed
@keithc-ca
Copy link
Contributor Author

Updated to remove -qhalt=e from the list of flags removed (it wasn't present before, I expect due to being removed by xlc.cmake).

@keithc-ca keithc-ca deleted the cmake branch July 9, 2025 21:00
@pshipton
Copy link
Member

pshipton commented Jul 10, 2025

AIX failing to compile again, all versions. I won't immediately revert in case there is a quick fix.
https://openj9-jenkins.osuosl.org/job/Build_JDK21_ppc64_aix_Nightly/557
https://openj9-jenkins.osuosl.org/job/Build_JDK8_ppc64_aix_Nightly/1068

19:33:02  [  8%] Building C object runtime/ddr/CMakeFiles/j9ddr_misc.dir/algorithm_versions.c.o
19:33:02  [  8%] Building CXX object runtime/omr/omr/CMakeFiles/omrcore.dir/OMR_Agent.cpp.o
19:33:02  error: 1540-5200 The option "-fno-eliminate-unused-debug-types" is not supported.
19:33:02  1 error generated.
19:33:02  Error while processing /home/jenkins/workspace/Build_JDK8_ppc64_aix_Nightly/openj9/runtime/ddr/algorithm_versions.c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants