Skip to content

Commit

Permalink
[P-Build] Avoid modified copies of build scripts for P-builds
Browse files Browse the repository at this point in the history
Contributes to:
- #2625
  • Loading branch information
HannesWell committed Jan 21, 2025
1 parent be370c0 commit a809de5
Show file tree
Hide file tree
Showing 9 changed files with 28 additions and 159 deletions.
15 changes: 0 additions & 15 deletions JenkinsJobs/YBuilds/P_build.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -149,21 +149,6 @@ spec:
\'\'\'
}
}
}
}
stage('Copy build scripts for P-build'){
steps {
container('jnlp') {
sh \'\'\'
cd ${WORKSPACE}/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/cje-production/P-build
cp mb220_buildSdkPatch.sh ${WORKSPACE}/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/cje-production/gitCache/eclipse.platform.releng.aggregator/cje-production/mbscripts/.
cp mb220_buildSdkPatch.sh ${WORKSPACE}/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/cje-production/mbscripts/.
cp mb300_gatherEclipseParts.sh ${WORKSPACE}/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/cje-production/gitCache/eclipse.platform.releng.aggregator/cje-production/mbscripts/.
cp mb300_gatherEclipseParts.sh ${WORKSPACE}/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/cje-production/mbscripts/.
cp mb620_promoteUpdateSite.sh ${WORKSPACE}/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/cje-production/gitCache/eclipse.platform.releng.aggregator/cje-production/mbscripts/.
cp mb620_promoteUpdateSite.sh ${WORKSPACE}/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/cje-production/mbscripts/.
\'\'\'
}
}
}
stage('Aggregator maven build'){
Expand Down
3 changes: 0 additions & 3 deletions RELENG.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,6 @@ When the JDT team is ready they will raise an issue to create new Y and P builds
- The modules listed in the top level pom file (`java##pathc/pom.xml) should match the modified plugins.
* Update the Y-build (Y_build.groovy)[JenkinsJobs/YBuilds/Y_build.groovy] and (P_build.groovy)[JenkinsJobs/YBuilds/P_build.groovy].
- Update `PATCH_OR_BRANCH_LABEL` and `BUILD_TYPE_NAME` to the name of the new java version
* Update the P-build (mb300_gatherEclipseParts.sh)[cje-production/P-build/mb300_gatherEclipseParts.sh].
- PATCH_BUILD_GENERIC in mb300_gatherEclipseParts.sh should be set to the name of the new maven profile
- The same variable in the normal (mb300_gatherEclipseParts)[cje-production/mbscripts/mb300_gatherEclipseParts.sh] should be updated as well.
* Update and rename the java repository files in (cje-production/streams)[cje-production/streams]
- Repos without a BETA_JAVA## branch should be set to master
* Update (eclipse-platform-parent/pom.xml)[eclipse-platform-parent/pom.xml]
Expand Down
50 changes: 0 additions & 50 deletions cje-production/P-build/mb220_buildSdkPatch.sh

This file was deleted.

42 changes: 0 additions & 42 deletions cje-production/P-build/mb300_gatherEclipseParts.sh

This file was deleted.

30 changes: 0 additions & 30 deletions cje-production/P-build/mb620_promoteUpdateSite.sh

This file was deleted.

3 changes: 2 additions & 1 deletion cje-production/mbscripts/mb110_tagBuildInputs.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash

#*******************************************************************************
# Copyright (c) 2019, 2021 IBM Corporation and others.
# Copyright (c) 2019, 2025 IBM Corporation and others.
#
# This program and the accompanying materials
# are made available under the terms of the Eclipse Public License 2.0
Expand All @@ -26,6 +26,7 @@ reportDate=$(TZ="America/New_York" date +%s)
reportTimestamp=$(TZ="America/New_York" date +%Y%m%d-%H%M --date='@'$reportDate)
gitLogFile=$CJE_ROOT/$DROP_DIR/$BUILD_ID/gitLog.html
mkdir -p $CJE_ROOT/$DROP_DIR/$BUILD_ID
mkdir -p $CJE_ROOT/$TMP_DIR

epUpdateDir=/home/data/httpd/download.eclipse.org/eclipse/updates
updateSiteRootPath=${epUpdateDir}/${STREAMMajor}.${STREAMMinor}-${BUILD_TYPE}-builds
Expand Down
17 changes: 12 additions & 5 deletions cje-production/mbscripts/mb220_buildSdkPatch.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash
#!/bin/bash -e

#*******************************************************************************
# Copyright (c) 2019 IBM Corporation and others.
# Copyright (c) 2019, 2025 IBM Corporation and others.
#
# This program and the accompanying materials
# are made available under the terms of the Eclipse Public License 2.0
Expand All @@ -13,7 +13,6 @@
# Contributors:
# Kit Lo - initial API and implementation
#*******************************************************************************
set -e

if [ $# -ne 1 ]; then
echo USAGE: $0 env_file
Expand All @@ -30,8 +29,17 @@ else
MVN_ARGS="-Pbree-libs -Peclipse-sign"
fi

mkdir -p $CJE_ROOT/$TMP_DIR
cd $CJE_ROOT/gitCache/eclipse.platform.releng.aggregator
mvn clean install -pl :eclipse-sdk-prereqs,:org.eclipse.jdt.core.compiler.batch -DlocalEcjVersion=99.99 -Dmaven.repo.local=$LOCAL_REPO -DcompilerBaselineMode=disable -DcompilerBaselineReplace=none
if [ -z "$PATCH_BUILD" ];then
mvn clean install -pl :eclipse-sdk-prereqs,:org.eclipse.jdt.core.compiler.batch \
-DlocalEcjVersion=99.99 \
-Dmaven.repo.local=$LOCAL_REPO -DcompilerBaselineMode=disable -DcompilerBaselineReplace=none
MVN_ARGS="${MVN_ARGS} -Dcbi-ecj-version=99.99"
else
MVN_ARGS="${MVN_ARGS} -f eclipse.platform.releng.tychoeclipsebuilder/${PATCH_OR_BRANCH_LABEL}/pom.xml -P${PATCH_OR_BRANCH_LABEL}"
fi

mvn clean verify -DskipTests=true ${MVN_ARGS} \
-Dtycho.debug.artifactcomparator \
-Dtycho.localArtifacts=ignore \
Expand All @@ -44,7 +52,6 @@ mvn clean verify -DskipTests=true ${MVN_ARGS} \
-DbuildType=$BUILD_TYPE \
-DbuildId=$BUILD_ID \
-Declipse-p2-repo.url=NOT_FOR_PRODUCTION_USE \
-Dcbi-ecj-version=99.99 \
-e \
-T 1C \
${JAVA_DOC_TOOL}
20 changes: 10 additions & 10 deletions cje-production/mbscripts/mb300_gatherEclipseParts.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash
#!/bin/bash -e

#*******************************************************************************
# Copyright (c) 2019, 2021 IBM Corporation and others.
# Copyright (c) 2019, 2025 IBM Corporation and others.
#
# This program and the accompanying materials
# are made available under the terms of the Eclipse Public License 2.0
Expand All @@ -13,7 +13,6 @@
# Contributors:
# Kit Lo - initial API and implementation
#*******************************************************************************
set -e

if [ $# -ne 1 ]; then
echo USAGE: $0 env_file
Expand All @@ -34,27 +33,29 @@ JavaCMD=${JAVA_HOME}/bin/java
cp $CJE_ROOT/$AGG_DIR/eclipse-platform-parent/target/mavenproperties.properties $CJE_ROOT/$DROP_DIR/$BUILD_ID/mavenproperties.properties

# gather repo
echo $PATCH_BUILD
if [ -z $PATCH_BUILD ]; then
echo "PATCH_BUILD: $PATCH_BUILD"
if [ -z "$PATCH_BUILD" ]; then
REPO_DIR=$PLATFORM_REPO_DIR
REPO_ZIP=$PLATFORM_TARGET_DIR/eclipse.platform.repository-${STREAMMajor}.${STREAMMinor}.${STREAMService}-SNAPSHOT.zip
else
PATCH_BUILD_GENERIC=java18patch
REPO_DIR=$ECLIPSE_BUILDER_DIR/$PATCH_BUILD/eclipse.releng.repository.$PATCH_BUILD_GENERIC/target/repository
REPO_ZIP=$ECLIPSE_BUILDER_DIR/$PATCH_BUILD/eclipse.releng.repository.$PATCH_BUILD_GENERIC/target/eclipse.releng.repository.$PATCH_BUILD_GENERIC-${STREAMMajor}.${STREAMMinor}.${STREAMService}-SNAPSHOT.zip
REPO_DIR=$ECLIPSE_BUILDER_DIR/$PATCH_BUILD/eclipse.releng.repository.${PATCH_BUILD}/target/repository
fi

if [ -d $REPO_DIR ]; then
pushd $REPO_DIR
cp -r * $CJE_ROOT/$UPDATES_DIR/$BUILD_ID
popd
fi

if [ -n "$PATCH_BUILD" ]; then
exit 0 # Nothing more to do for patch-builds
fi

if [ -f $REPO_ZIP ]; then
cp $REPO_ZIP $CJE_ROOT/$DROP_DIR/$BUILD_ID/repository-$BUILD_ID.zip
fi


if [ -z $PATCH_BUILD ]; then
# gather sdk
if [ -d $PLATFORM_PRODUCTS_DIR ]; then
pushd $PLATFORM_PRODUCTS_DIR
Expand Down Expand Up @@ -131,7 +132,6 @@ if [ -z $PATCH_BUILD ]; then
popd
fi
set +x
fi

# gather ecj jars
ECJ_JAR_DIR=$CJE_ROOT/$AGG_DIR/eclipse.jdt.core/org.eclipse.jdt.core.compiler.batch/target
Expand Down
7 changes: 4 additions & 3 deletions cje-production/mbscripts/mb620_promoteUpdateSite.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash
#!/bin/bash -e

#*******************************************************************************
# Copyright (c) 2019 IBM Corporation and others.
# Copyright (c) 2019, 2025 IBM Corporation and others.
#
# This program and the accompanying materials
# are made available under the terms of the Eclipse Public License 2.0
Expand All @@ -13,7 +13,6 @@
# Contributors:
# Sravan Lakkimsetti - initial API and implementation
#*******************************************************************************
set -e

if [ $# -ne 1 ]; then
echo USAGE: $0 env_file
Expand All @@ -35,6 +34,8 @@ popd
if [ "$COMPARATOR_ERRORS" == "true" ] && [ "$BUILD_TYPE" == "I" ]
then
exit 0
elif [ "$BUILD_TYPE" == "P" ]; then
exit 0
fi

epDownloadDir=/home/data/httpd/download.eclipse.org/eclipse
Expand Down

0 comments on commit a809de5

Please sign in to comment.