Application icon doesn't render after upgrading

[eobrienPilz]

Important

If you are reporting a crash on Linux, please check if webkit is mentioned in the crash file.
If yes, please try to set WEBKIT_DISABLE_COMPOSITING_MODE=1 and/or WEBKIT_DISABLE_DMABUF_RENDERER=1 environment variables.
If they prevent crashes, don't report the bug please, it is already known as #843

Describe the bug
Our Eclipse RCP application icon is not displayed in the windows tray or the top left corner on Windows.

To Reproduce
The issue can be reproduced with the following image.

Eclipse window without icon

Task switcher without icon

Expected behavior
The icon show appear as normal like it did in 4.34

Environment:

1. Select the platform(s) on which the behavior is seen:

• • All OS
• • Windows
• • Linux
• • macOS

2. Additional OS info (e.g. OS version, Linux Desktop, etc)

3. JRE/JDK version

Version since
4.37

Workaround (or) Additional context
Add any other context about the problem here.
Any known workarounds for the problem?

[HeikoKlare]

I cannot reproduce this. I've placed the posted icon into an SDK Product (based on the org.eclipse.ui.ide.workbench application) and it properly appears in the title bar of the application, in the tray and the like:

I used the latest Eclipse (and in particular SWT) master state for testing.

Did you try with the latest code state or I-Build? Do you use any monitor scaling other than 100%? Can you provide a snippet that demonstrates the issue?

[eobrienPilz]

I just set up the SDK today so it should be up to date. Having said that, when I downloaded the image just now and put it into eclipse it displayed ok for me, so I can't reproduce with this image now either.

This is the original png that we use.

Maybe the different filename could help in case there is anything getting cached.

I made the update to the xml here: eclipse.platform\platform\org.eclipse.sdk\plugin.xml

See: property name="windowImages" value
`

<extension id="ide" point="org.eclipse.core.runtime.products"> 
  <product name="%productName" application="org.eclipse.ui.ide.workbench" description="%productBlurb"> 
      <property name="windowImages" value="pilz48.svg"/> 
      <property name="aboutImage" value="eclipse_lg.png"/> 
      <property name="aboutText" value="%productBlurb"/> 
      <property name="appName" value="Eclipse"/> 
      <property name="preferenceCustomization" value="plugin_customization.ini"/>
      <property

`

[HeikoKlare]

Thank you for sharing the original PNG. With that file, I can reproduce the issue. It may be related to the handling of transparency/mask data. When I comment out the following if block, the icon is displayed:

eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java

Lines 1185 to 1188 in ac18a18

	if (data.alpha == -1 && data.alphaData == null) {
	ImageData mask = data.getTransparencyMask ();
	return new Image (device, data, mask);
	}

That's obviously not the proper fix but an indicator that we may have some regression in transparency handling.

Since your xml file mentions an SVG: do you experience the same issue with an SVG version of that icon?

In any case, we will have a look at what introduced this regression.