Exclude TODO tests by default, include them with runtodotests label #2765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 118 files 118 suites 16m 49s ⏱️ Results for commit ebc9d1e. ♻️ This comment has been updated with latest results. |
jonahgraham
force-pushed
the
runtodotests
branch
2 times, most recently
from
1dfaa1f to
a533ff9
Compare
Contributor
Author
|
The runtodotests label is https://github.com/eclipse-platform/eclipse.platform.swt/issues?q=label%3Aruntodotests |
In eclipse-platform#2757 the idea of using `@Tag("gtk4-todo")` was introduced to tag tests that are known TODO as such. This commit adds todos to the exclude groups list when running such tests. There are not actually any GTK3 x11 todos yet, so this commit on its own may not make sense until GTK4 + wayland tests are enabled in a subsequent commit Apply the label runtodotests to the PR and the todo tests will not be excluded. Part of eclipse-platform#2714
jonahgraham
force-pushed
the
runtodotests
branch
from
a533ff9 to
ebc9d1e
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2757 the idea of using
@Tag("gtk4-todo")was introduced to tag tests that are known TODO as such. This commit adds todos to the exclude groups list when running such tests.There are not actually any GTK3 x11 todos yet, so this commit on its own may not make sense until GTK4 + wayland tests are enabled in a subsequent commit
Apply the label runtodotests to the PR and the todo tests will not be excluded.
Part of #2714
In draft until dependent PR #2764 is merged.