Compile errors in org.eclipse.e4.core.internal.tests.contexts.performance.ContextPerformanceTest

[merks]

Today I updated everything in my SDK setup. including the installation and now I get these errors:

You see the corresponding method exists, but it's confused about methods that use junit.framework.TestCase in the signature.

Adding this import makes the error go away:

But that seems fishy to me.

@iloveeclipse

Maybe something changed in JDT? I.e., is this a bug?

[laeubi]

@merks this is likely an incarnation of the following:

• Do not emit restriction warning on inherited method eclipse-jdt/eclipse.jdt.core#4293

sadly @stephan-herrmann seems busy at the moment so we have no conclusion yet, but if that would be accepted such stupid strange and hard to understand errors would be gone. It currently depend on what methods are called and if the super class method is override or not.

As Tycho is working a bit differently as PDE, it might be that the verification/i-build even succeeds while you get an error in the IDE... sometimes its the other way round so very annoying!

[akurtakov]

For the record, I can see the problem in a workspace with eclipse.platform too using latest I-build.

[stephan-herrmann]

Where can I find the affected projects? My search for org.eclipse.e4.core.tests or org.eclipse.e4.core.javax.tests yielded nothing.

[laeubi]

I would assume it is this one here https://github.com/eclipse-platform/eclipse.platform/blob/master/runtime/tests/org.eclipse.e4.core.tests/src/org/eclipse/e4/core/internal/tests/contexts/performance/ContextPerformanceTest.java

[stephan-herrmann]

Class PerformanceTestRunner these methods:

• run(TestCase, int, int)
• run(TestCase, String, int, int)
• run(Class<?>, String, int, int)

When you invoke someRunner.run(x,"", 1, 2) or similar the compiler needs to determine if x conforms to type TestCase in order to decide which method is being called. If TestCase is not available, the compiler cannot perform the checks required by JLS.

[merks]

While that makes sense, this is new behavior, and previously this was not a problem. Of course one has to wonder why the class that I'm not using and as is available in the bundle that defines the run methods is not available.

[stephan-herrmann]

While that makes sense, this is new behavior, and previously this was not a problem.

Can you identify when exactly this behavior first surfaced?
Did it break any I-build?

[stephan-herrmann]

While that makes sense, this is new behavior, and previously this was not a problem.

Can you identify when exactly this behavior first surfaced? Did it break any I-build?

To answer my own question: this happens since eclipse-pde/eclipse.pde#2011

[laeubi]

Oops, then forget about my idea in #2200 (comment) it is a different case here.