Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stored launch configs of nested projects shown twice #798

Open
Bananeweizen opened this issue Nov 1, 2023 · 3 comments · May be fixed by #856
Open

Stored launch configs of nested projects shown twice #798

Bananeweizen opened this issue Nov 1, 2023 · 3 comments · May be fixed by #856
Labels
bug Something isn't working

Comments

@Bananeweizen
Copy link
Contributor

If projects are nested (which is typical for maven reactor and modules), then launch configs stored in the nested project are shown twice in the run drop down. It might be useful to implement equals/hashCode such that the absolute file system paths are compared (or to alternatively filter based on the absolute file system path).

grafik
@Bananeweizen Bananeweizen mentioned this issue Nov 1, 2023
Closed
@jukzi jukzi added bug Something isn't working regression Regression defect labels Nov 2, 2023
@jukzi
Copy link
Contributor

jukzi commented Nov 2, 2023

@mickaelistria can you please look into all those duplicate launch config issues.

@laeubi
Copy link
Contributor

laeubi commented Nov 2, 2023

@jukzi this is a completely different menu so not related to #527

@Bananeweizen can you please explain from what Eclipse version this is a regression?

@Bananeweizen
Copy link
Contributor Author

@laeubi I'm not sure that this is a regression. I think it has always been that way. https://github.com/eclipse-platform/eclipse.platform/blame/9802acd4bfbe3995960cfaafd713c76fc1ceda74/debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/LaunchConfiguration.java#L372 is unchanged since 15 years and that location comparison leads to projectA/project/B/C.launch not being considered the same as projectB/C.launch.

@laeubi laeubi removed the regression Regression defect label Nov 2, 2023
@Bananeweizen Bananeweizen linked a pull request Nov 11, 2023 that will close this issue
Open
jukzi pushed a commit to Bananeweizen/eclipse.platform that referenced this issue Mar 8, 2024
@Bananeweizen @jukzi
Deduplicate stored launch configs of nested projects eclipse-platform…
a359e6e 
…#798

Fixes eclipse-platform#798.

m2e projects can be nested (e.g. modules stored inside a reactor).
Launch configs stored the inner nested projects appear twice, because
they are not equal with the old implementation checking only name and
container. Therefore also check the resolved location if the containers
are different.

I've tested this with an m2e IDE containing such nested projects and
stored launch configs. The duplicates are gone with the change.
HannesWell pushed a commit to Bananeweizen/eclipse.platform that referenced this issue Sep 29, 2024
@Bananeweizen @HannesWell
Deduplicate stored launch configs of nested projects eclipse-platform…
a742866 
…#798

Fixes eclipse-platform#798.

m2e projects can be nested (e.g. modules stored inside a reactor).
Launch configs stored the inner nested projects appear twice, because
they are not equal with the old implementation checking only name and
container. Therefore also check the resolved location if the containers
are different.

I've tested this with an m2e IDE containing such nested projects and
stored launch configs. The duplicates are gone with the change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deduplicate stored launch configs of nested projects #798 Bananeweizen/eclipse.platform
3 participants
@Bananeweizen @laeubi @jukzi