Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs have close button on the wrong side on macOS #460

Open
cdamus opened this issue Feb 10, 2025 · 0 comments · May be fixed by eclipse-theia/theia#15103
Open

Tabs have close button on the wrong side on macOS #460

cdamus opened this issue Feb 10, 2025 · 0 comments · May be fixed by eclipse-theia/theia#15103

Comments

@cdamus
Copy link

cdamus commented Feb 10, 2025

Bug Description:

In macOS, tabbed window interfaces have the close button for a tab on the left side of the tab. Theia has them on the right hand side.

Steps to Reproduce:

  1. Launch Theia IDE.
  2. Open a file in an editor.
  3. See the close button for the tab appear on the right-hand side of the tab title when hovering the pointer over it.

Additional Information

  • Operating System: macOS Sequoia 15.3 on M4 Max
  • Theia Version: 1.58.100.202

This:

Image

should be like this:

Image
cdamus added a commit to cdamus/theia that referenced this issue Mar 3, 2025
@cdamus
Put close icons at the start of the tab label by default on macOS
e6400e7 
Add a new window.tabCloseIconPlacement preference for whether to present
the Close (X) icon in tab titles on the left or the right of the tab.
Default to the left on macOS platform in conformity with the OS's native
tab controls.

Fixes eclipse-theia/theia-ide#460

Signed-off-by: Christian W. Damus <[email protected]>
cdamus added a commit to cdamus/theia that referenced this issue Mar 3, 2025
@cdamus
Put close icons at the start of the tab label by default on macOS
22b0937 
Add a new window.tabCloseIconPlacement preference for whether to present
the Close (X) icon in tab titles on the left or the right of the tab.
Default to the left on macOS platform in conformity with the OS's native
tab controls.

Fixes eclipse-theia/theia-ide#460

Signed-off-by: Christian W. Damus <[email protected]>
cdamus added a commit to cdamus/theia that referenced this issue Mar 3, 2025
@cdamus
Put close icons at the start of the tab label by default on macOS
32cc3de 
Add a new window.tabCloseIconPlacement preference for whether to present
the Close (X) icon in tab titles on the left or the right of the tab.
Default to the left on macOS platform in conformity with the OS's native
tab controls.
Show the new preference in the Settings UI on macOS platform only.

Render the tab title with the icon on the left or right accordingly.

Fixes eclipse-theia/theia-ide#460

Signed-off-by: Christian W. Damus <[email protected]>
@cdamus cdamus linked a pull request Mar 3, 2025 that will close this issue
Open
2 tasks
cdamus added a commit to cdamus/theia that referenced this issue Mar 3, 2025
@cdamus
Put close icons at the start of the tab label by default on macOS
69af7eb 
Add a new window.tabCloseIconPlacement preference for whether to present
the Close (X) icon in tab titles on the left or the right of the tab.
Default to the left on macOS platform in conformity with the OS's native
tab controls.
Show the new preference in the Settings UI on macOS platform only.

Render the tab title with the icon on the left or right accordingly.

Fixes eclipse-theia/theia-ide#460

Signed-off-by: Christian W. Damus <[email protected]>
Signed-off-by: Christian W. Damus <[email protected]>
cdamus added a commit to cdamus/theia that referenced this issue Mar 3, 2025
@cdamus
Put close icons at the start of the tab label by default on macOS
6dc0c58 
Add a new window.tabCloseIconPlacement preference for whether to present
the Close (X) icon in tab titles on the left or the right of the tab.
Default to the left on macOS platform in conformity with the OS's native
tab controls.
Show the new preference in the Settings UI on macOS platform only.

Render the tab title with the icon on the left or right accordingly.

Fixes eclipse-theia/theia-ide#460

Signed-off-by: Christian W. Damus <[email protected]>
cdamus added a commit to cdamus/theia that referenced this issue Mar 26, 2025
@cdamus
Put close icons at the start of the tab label by default on macOS
ecc64bd 
Add a new window.tabCloseIconPlacement preference for whether to present
the Close (X) icon in tab titles on the left or the right of the tab.
Default to the left on macOS platform in conformity with the OS's native
tab controls.
Show the new preference in the Settings UI on macOS platform only.

Render the tab title with the icon on the left or right accordingly.

Fixes eclipse-theia/theia-ide#460

Signed-off-by: Christian W. Damus <[email protected]>
cdamus added a commit to cdamus/theia that referenced this issue Mar 27, 2025
@cdamus
Put close icons at the start of the tab label by default on macOS
37c7cbb 
Add a new window.tabCloseIconPlacement preference for whether to present
the Close (X) icon in tab titles on the left or the right of the tab.
Default to the left on macOS platform in conformity with the OS's native
tab controls.
Show the new preference in the Settings UI on macOS platform only.

Render the tab title with the icon on the left or right accordingly.

Fixes eclipse-theia/theia-ide#460

Signed-off-by: Christian W. Damus <[email protected]>
Signed-off-by: Christian W. Damus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Put close icons at the start of the tab label by default on macOS cdamus/theia
1 participant
@cdamus