Tycho and non existing classpath elements

[laeubi]

Currently ECJ complains about folders/jars that do not exits at the time the compiler is invoked.

The obvious fix for Tycho seems to exclude non existing locations in

tycho/tycho-compiler-plugin/src/main/java/org/eclipse/tycho/compiler/AbstractOsgiCompilerMojo.java

Lines 489 to 494 in 02e406b

	for (File location : cpe.getLocations()) {
	String entry = location.getAbsolutePath() + toString(cpe.getAccessRules());
	if (seen.add(entry)) {
	classpath.add(entry);
	}
	}

But there is actually an explicit test that tycho return non existing locations here:

tycho/tycho-compiler-plugin/src/test/java/org/eclipse/tycho/osgicompiler/test/OsgiCompilerTest.java

Lines 143 to 152 in 02e406b

	// project with a (not yet) existing nested jar that would be copied later during build
	// (wrapper scenario with copy-pom-dependencies)
	project = projects.get(4);
	mojo = getMojo(projects, project);
	mojo.execute();
	cp = mojo.getClasspathElements();
	assertEquals(3, cp.size());
	assertEquals(getClasspathElement(project.getBasedir(), "target/classes", ""), cp.get(0));
	assertEquals(getClasspathElement(project.getBasedir(), "lib/not_existing_yet.jar", ""), cp.get(1));
	assertEquals(getClasspathElement(project.getBasedir(), "lib/not_existing_yet_dir/", ""), cp.get(2));

AbstractOsgiCompilerMojo#getClasspathElements() is effectively called right at the execute phase so I really don't see any chance that a non existing item is created/copied anywhere and assume the test is either wrong or incomplete.

@mickaelistria @akurtakov do you have any insights if/how non existing items can be important at this phase? If not I'd like to adjust the test and skip non existing items to prevent unnecessary error printouts.

FYI @iloveeclipse

[laeubi]

As it seems there are no concern I plan to disable the test and apply the filtering of non existing items next week.

[laeubi]

As it seems there are no concern I plan to disable the test and apply the filtering of non existing items next week.

Done with

• Skip non existing classpath entries in compile phase #1682