Follow up Question to partially building with --am in mixed-rteactor setup

[phermsdorf]

Hi,

follow-up question to #1017

Could it be that this does not work in mixed-reactor setup's?

So i have a eclipse-plugin module which references another reactor module in the MANIFEST.MF which generates a MANFEST.MF with the maven-bundle-plugin.

When i try to build that with

mvn clean verify -am

in the subdirectory of the eclipse-plugin maven module it cannot find the references module. The build stops with something like

Cannot resolve project dependencies:
   Software being installed: com.company.rcp.client.rmi.osgi 14.0.0.qualifier
   Missing requirement: com.company.rcp.client.rmi.osgi 14.0.0.qualifier requires 'osgi.bundle; com.company.Remote [14.0.0,15.0.0)' but it could not be found

I have referenced the Remote Module in the eclipse-plugin module's pom.xml via it's maven coordinates. In the full build that works as expected.

Thanks for any hints on this.

Bye Peter

[laeubi]

When i try to build that with

mvn clean verify -am

without a -pl? Have you enabled the tycho-build extension in the .mvn/extensions.xml?

[phermsdorf]

I includes tycho in the section with

<plugin>
        <groupId>org.eclipse.tycho</groupId>
        <artifactId>tycho-maven-plugin</artifactId>
        <version>4.0.13</version>
        <extensions>true</extensions>
</plugin>

Is it crucial to do it in the extension.xml?

I tried to avoid using -pl and instead to start the build from the subdirectory of the module, because I want to use a shared maven eclipse launch where i can use ${selected_resource_loc} as Base Directory value.
With that in place i can start such a "sub tree" build just by right clicking on the module and then select "Run as -> BuildWithDependenModules" (or however the shared maven launch is called).

That would easy the usage extremely. Otherwise one has to adjust the -pl line every time which can be very cumbersome in deeper project structures.
Maybe you have an idea how that could be changed or adjusted to work...

When starting the build from the root parent with -pl parent2/module-name -am it does work to some degree.

My observation:

1. it does build dependent "pure" maven modules and executes their tests
2. when it comes to building the actual module the build fails with a similar message like in my first post, but this time it is a regular eclipse-plugin module, not even a generated one (that module is a child module of another parallel parent project, so it is there)
3. when referencing a test fragment with -pl it does not pull in the fragment host bundle (and it's dependent modules) and then fails after the target is resolved with a Missing requirement error

Thanks for your comments.

Bye Peter

[laeubi]

Is it crucial to do it in the extension.xml?

If you don't do it there option like -am an -pl will not work reliable unless you specify every dependency in the pom. This is because maven needs to call Tycho before even the pom file is known.

I tried to avoid using -pl and instead to start the build from the subdirectory of the module, because I want to use a shared maven eclipse launch where i can use ${selected_resource_loc} as Base Directory value.

I'm not sure this work as I never tried that, but maybe maven is smart enough. Does it work for plain maven projects?

By the way here is an integration test that shows the current working behavior:

• https://github.com/eclipse-tycho/tycho/tree/main/tycho-its/projects/reactor.makeBehaviour
• https://github.com/eclipse-tycho/tycho/blob/main/tycho-its/src/test/java/org/eclipse/tycho/test/reactor/makeBehaviour/MavenReactorMakeOptionsTest.java

[phermsdorf]

After registering tycho as extension in the extensions.xml everything seems to work now.
Playing around with the integration test helped a lot.

For the record: running with -am from the directory of the sub module to build does not build the dependant modules, it only builds this conrete module.
So one has to use -pl artifactID with -am.

Thanks again for the helpful information @laeubi !

[laeubi]

For the record: running with -am from the directory of the sub module to build does not build the dependant modules, it only builds this conrete module.

I think this is intentional, because what -pl ... -am does is select a project (and dependents) from the whole set of reactor project. So running from the sub directory you only have one project there.

It sound still useful, but would require some extension in maven itself I think ...