tycho 2.7.0 not copying/unpacking justj to target/justj

[alshubei]

I am wondering if someone can help me why the below maven is not working with tycho > 2.3.0. It worked with tycho 1.7.
So why is the maven-dependency-plugin not able to find and copy the stated p2 resources which is justj? The only difference to the previous working state is the tycho version. There is no more logs to show in this regard.

<build>
		<plugins>
			<plugin>
				<groupId>org.eclipse.tycho</groupId>
				<artifactId>target-platform-configuration</artifactId>
				<version>${tycho-version}</version>
				<configuration>
				 <executionEnvironment>org.eclipse.justj.openjdk.hotspot.jre.full-11</executionEnvironment>
					<dependency-resolution>
						<extraRequirements>
							<requirement>
								<type>eclipse-plugin</type>
								<id>org.eclipse.justj.openjdk.hotspot.jre.full.stripped</id>
								<versionRange>0.0.0</versionRange>
							</requirement>
						</extraRequirements>
						<profileProperties>
			                <org.eclipse.justj.buildtime>true</org.eclipse.justj.buildtime>
			             </profileProperties>
					</dependency-resolution>
				</configuration>
			</plugin>
			<plugin>
				<groupId>org.apache.maven.plugins</groupId>
				<artifactId>maven-dependency-plugin</artifactId>
				<version>3.3.0</version>
				<executions>
					<execution>
						<id>1_copy-dependencies</id>
						<phase>process-resources</phase>
						<goals>
							<goal>unpack-dependencies</goal>
						</goals>
						<configuration>
							<outputDirectory>target/justj</outputDirectory>
							<overWriteIfNewer>true</overWriteIfNewer>
							<includeArtifactIds>org.eclipse.justj.openjdk.hotspot.jre.full.stripped.win32.x86_64,org.eclipse.justj.openjdk.hotspot.jre.full.stripped.linux.x86_64</includeArtifactIds>
						</configuration>
					</execution>
				</executions>
			</plugin>

Before that, I have a p2 repo section for tycho to look at

			<id>justj</id>
			<layout>p2</layout>
			<url>https://download.eclipse.org/justj/jres/11/updates/release/</url> 
		</repository>

[cdietrich]

here is a small reproducer
https://github.com/cdietrich/tycho-discussion-934-preproducer
bisecting shows it broke in 2.2.0

[laeubi]

Probably, the question is: What 'feature' they really rely on? Is this for fetching a jvm? It would probably better to then reference the jar directly as a maven system scoped dependency or ask JustJ to deploy maven artifacts at first place.

[cdietrich]

ususally: package justj in product and "patch" it by adding custom certs

[laeubi]

If you include the justj feature in a product it will be included, so why not patch it before the product is zip/tar.gz'ed?

[cdietrich]

i dont know. i just play man in the middle now ;)

[alshubei]

not really I'm a bit unsure what is the expected outcome here why should justj be a dependency and why one wants to unpack it? Should not including the feature be enough? what does dependency:tree shows here?

The reason of this copy step was to just (shortly using ant) keytool a .cer file to ${jvm.path}/lib/security/cacerts then move it to ${basedir}/rootfiles/configuration/cacerts. So that the final eclipse product will point to a jre from justj plus that modified cacerts. The shortly aside copied/unpacked justj is eventually ignored