Rename QuicConnection#createStream to QuicConnection#openStream.

Author: vietj

vertx-core/src/main/java/io/vertx/core/net/QuicConnection.java

@@ -55,21 +55,21 @@ public interface QuicConnection {
   QuicConnection closeHandler(Handler<Void> handler);
 
   /**
-   * Create a bidirectional stream to the remote endpoint.
+   * Open a bidirectional stream to the remote endpoint.
    *
    * @return a Quic stream as a future
    */
-  default Future<QuicStream> createStream() {
-    return createStream(true);
+  default Future<QuicStream> openStream() {
+    return openStream(true);
   }
 
   /**
-   * Create a stream to the remote endpoint.
+   * Open a stream to the remote endpoint with {@code bidirectional parameter} specifying its directionality.
    *
    * @param bidirectional whether the stream is unidirectional or bidirectional
    * @return A Quic stream as a future
    */
-  Future<QuicStream> createStream(boolean bidirectional);
+  Future<QuicStream> openStream(boolean bidirectional);
 
   /**
    * Set a handler called with the datagram addressed to this connection.

vertx-core/src/main/java/io/vertx/core/net/impl/quic/QuicConnectionImpl.java

@@ -202,7 +202,7 @@ public Future<QuicStream> createStream(ContextInternal context) {
   }
 
   @Override
-  public Future<QuicStream> createStream(boolean bidirectional) {
+  public Future<QuicStream> openStream(boolean bidirectional) {
     return createStream(vertx.getOrCreateContext(), bidirectional);
   }
 

vertx-core/src/test/java/io/vertx/tests/net/quic/QuicApplicationTest.java

@@ -200,7 +200,7 @@ public void testStreamLevel() {
     QuicClient client = QuicClient.create(vertx, clientOptions);
     client.bind(SocketAddress.inetSocketAddress(0, "localhost")).await();
     QuicConnectionInternal connection = (QuicConnectionInternal) client.connect(SocketAddress.inetSocketAddress(9999, "localhost")).await();
-    QuicStreamInternal stream = (QuicStreamInternal) connection.createStream().await();
+    QuicStreamInternal stream = (QuicStreamInternal) connection.openStream().await();
     ChannelPipeline pipeline = stream.channelHandlerContext().pipeline();
     pipeline.addBefore("handler", "http", new HttpClientCodec());
     pipeline.addBefore("handler", "aggregator", new HttpObjectAggregator(1014));

vertx-core/src/test/java/io/vertx/tests/net/quic/QuicClientTest.java

@@ -10,8 +10,6 @@
  */
 package io.vertx.tests.net.quic;
 
-import io.netty.channel.nio.NioEventLoopGroup;
-import io.netty.util.NetUtil;
 import io.vertx.core.Future;
 import io.vertx.core.buffer.Buffer;
 import io.vertx.core.net.*;
@@ -23,7 +21,6 @@
 import org.junit.runner.RunWith;
 
 import javax.net.ssl.SSLHandshakeException;
-import java.net.InetSocketAddress;
 import java.time.Duration;
 import java.util.ArrayList;
 import java.util.Collections;
@@ -120,7 +117,7 @@ public void testCreateStream() throws Exception {
     server.bind(SocketAddress.inetSocketAddress(9999, "localhost")).await();
     client.bind(SocketAddress.inetSocketAddress(0, "localhost")).await();
     QuicConnection connection = client.connect(SocketAddress.inetSocketAddress(9999, "localhost")).await();
-    QuicStream stream = connection.createStream().await();
+    QuicStream stream = connection.openStream().await();
     List<Buffer> received = Collections.synchronizedList(new ArrayList<>());
     stream.handler(buff -> received.add(buff));
     CountDownLatch latch = new CountDownLatch(1);
@@ -151,7 +148,7 @@ public void testServerReset() {
 
     client.bind(SocketAddress.inetSocketAddress(0, "localhost")).await();
     QuicConnection connection = client.connect(SocketAddress.inetSocketAddress(9999, "localhost")).await();
-    QuicStream stream = connection.createStream().await();
+    QuicStream stream = connection.openStream().await();
 
     stream.exceptionHandler(t -> complete());
     stream.closeHandler(v -> complete());
@@ -179,7 +176,7 @@ public void testClientReset() {
 
     client.bind(SocketAddress.inetSocketAddress(0, "localhost")).await();
     QuicConnection connection = client.connect(SocketAddress.inetSocketAddress(9999, "localhost")).await();
-    QuicStream stream = connection.createStream().await();
+    QuicStream stream = connection.openStream().await();
 
     AtomicBoolean isReset = new AtomicBoolean();
     Buffer buffer = Buffer.buffer();
@@ -225,7 +222,7 @@ public void testClientResetHandler() {
 
     client.bind(SocketAddress.inetSocketAddress(0, "localhost")).await();
     QuicConnection connection = client.connect(SocketAddress.inetSocketAddress(9999, "localhost")).await();
-    QuicStream stream = connection.createStream().await();
+    QuicStream stream = connection.openStream().await();
 
     stream.exceptionHandler(t -> fail());
     stream.resetHandler(code -> {
@@ -275,7 +272,7 @@ public void testShutdown(boolean shutdownConnection) throws Exception {
 
     AtomicInteger shutdownCount = new AtomicInteger();
     for (int i = 0;i < numStreams;i++) {
-      QuicStream stream = connection.createStream().await();
+      QuicStream stream = connection.openStream().await();
       stream.shutdownHandler(v -> {
         shutdownCount.incrementAndGet();
         vertx.setTimer(100, id -> {

vertx-core/src/test/java/io/vertx/tests/net/quic/QuicContextTest.java

@@ -77,7 +77,7 @@ public void testServerConnectionScoped() {
     client.bind(SocketAddress.inetSocketAddress(0, "localhost")).await();
     QuicConnection connection = client.connect(SocketAddress.inetSocketAddress(9999, "localhost")).await();
     QuicStream stream = connection
-      .createStream().await();
+      .openStream().await();
     stream.end(Buffer.buffer("ping")).await();
     await();
   }
@@ -104,7 +104,7 @@ public void testServerStreamScoped() {
     Future.future(p -> workerContext.runOnContext(v -> server.bind(SocketAddress.inetSocketAddress(9999, "localhost")).onComplete(p))).await();
     client.bind(SocketAddress.inetSocketAddress(0, "localhost")).await();
     QuicConnection connection = client.connect(SocketAddress.inetSocketAddress(9999, "localhost")).await();
-    QuicStream stream = connection.createStream().await();
+    QuicStream stream = connection.openStream().await();
     stream.end(Buffer.buffer("ping")).await();
     await();
   }
@@ -145,7 +145,7 @@ public void testClientStreamScoped() {
 
     QuicConnection connection = client.connect(SocketAddress.inetSocketAddress(9999, "localhost")).await();
 
-    QuicStream stream = Future.<QuicStream>future(p -> workerContext.runOnContext(v -> connection.createStream().onComplete(p))).await();
+    QuicStream stream = Future.<QuicStream>future(p -> workerContext.runOnContext(v -> connection.openStream().onComplete(p))).await();
 
     AtomicInteger cnt = new AtomicInteger();
     stream.handler(buff -> {
@@ -187,7 +187,7 @@ public void testStreamContextProvider() {
     server.bind(SocketAddress.inetSocketAddress(9999, "localhost")).await();
     client.bind(SocketAddress.inetSocketAddress(0, "localhost")).await();
     QuicConnection connection = client.connect(SocketAddress.inetSocketAddress(9999, "localhost")).await();
-    QuicStream stream = connection.createStream().await();
+    QuicStream stream = connection.openStream().await();
     stream.end(Buffer.buffer("ping")).await();
     await();
   }

vertx-core/src/test/java/io/vertx/tests/net/quic/QuicFlowControlTest.java

@@ -11,8 +11,6 @@
 package io.vertx.tests.net.quic;
 
 import io.netty.buffer.ByteBuf;
-import io.netty.handler.codec.http.*;
-import io.netty.handler.codec.http3.*;
 import io.vertx.core.Completable;
 import io.vertx.core.buffer.Buffer;
 import io.vertx.core.internal.buffer.BufferInternal;
@@ -75,7 +73,7 @@ public void testFlowControl() {
     client.bind(SocketAddress.inetSocketAddress(0, "localhost")).await();
     QuicConnection connection = client.connect(SocketAddress.inetSocketAddress(9999, "localhost")).await();
     connection
-      .createStream()
+      .openStream()
       .onComplete(onSuccess2(stream -> {
         stream.pause();
         QuicStreamInternal streamInternal = (QuicStreamInternal) stream;

vertx-core/src/test/java/io/vertx/tests/net/quic/QuicMetricsTest.java

@@ -89,7 +89,7 @@ private void testMetrics(int numberOfServers) throws Exception {
     FakeQuicEndpointMetrics clientMetrics = FakeTransportMetrics.getMetrics(client);
     assertEquals(1, clientMetrics.connectionCount());
     SocketMetric clientConnectionMetric = clientMetrics.firstMetric(clientConnection.remoteAddress());
-    QuicStream clientStream = clientConnection.createStream().await();
+    QuicStream clientStream = clientConnection.openStream().await();
     List<Buffer> received = Collections.synchronizedList(new ArrayList<>());
     clientStream.handler(buff -> received.add(buff));
     CountDownLatch latch = new CountDownLatch(1);

vertx-core/src/test/java/io/vertx/tests/net/quic/QuicServerTest.java

@@ -207,7 +207,7 @@ public void testServerConnectionClose() throws Exception {
   public void testServerCreatesStream() throws Exception {
     QuicServer server = QuicServer.create(vertx, serverOptions());
     server.handler(conn -> {
-      conn.createStream().onComplete(onSuccess2(stream -> {
+      conn.openStream().onComplete(onSuccess2(stream -> {
         stream.write("ping");
         stream.handler(buff -> {
           assertEquals("pong", buff.toString());
@@ -235,7 +235,7 @@ public void testServerCreatesUniStream() throws Exception {
     disableThreadChecks();
     QuicServer server = QuicServer.create(vertx, serverOptions());
     server.handler(conn -> {
-      conn.createStream(false).onComplete(onSuccess2(stream -> {
+      conn.openStream(false).onComplete(onSuccess2(stream -> {
         assertFalse(stream.isBidirectional());
         assertTrue(stream.isLocalCreated());
         stream.write("ping");