Avoid UUID.randomUUID() in startup code

This is done because bootstrapping the plumbing
needed by the JDK to produce a UUID value
is expensive, it thus doesn't make sense to
pay this cost when the property isn't actually
needed

Author: geoand

vertx-core/src/main/java/io/vertx/core/file/impl/FileCache.java

@@ -45,8 +45,7 @@ static File setupCacheDir(String fileCacheDir) {
 
     // the cacheDir will be suffixed a unique id to avoid eavesdropping from other processes/users
     // also this ensures that if process A deletes cacheDir, it won't affect process B
-    String cacheDirName = fileCacheDir + "-" + UUID.randomUUID();
-    File cacheDir = new File(cacheDirName);
+    File cacheDir = effectiveCacheDir(fileCacheDir);
     // Create the cache directory
     try {
       if (Utils.isWindows()) {
@@ -63,6 +62,25 @@ static File setupCacheDir(String fileCacheDir) {
     return cacheDir;
   }
 
+  private static File effectiveCacheDir(String fileCacheDir) {
+    for(int i = 0; i < 10; i++) {
+      try {
+        // attempt to create a file using a really quick random value
+        String cacheDirName = fileCacheDir + "-" + System.nanoTime();
+        File file = new File(cacheDirName);
+        Files.createDirectories(file.toPath());
+        return file;
+      } catch(FileAlreadyExistsException ignore) {
+      } catch (IOException ignore) {
+        // hope that the fallback will work
+        break;
+      }
+    }
+
+    String cacheDirName = fileCacheDir + "-" + UUID.randomUUID();
+    return new File(cacheDirName);
+  }
+
   private Thread shutdownHook;
   private File cacheDir;
 

vertx-core/src/main/java/io/vertx/core/impl/deployment/DefaultDeploymentManager.java

@@ -36,7 +36,12 @@ public DefaultDeploymentManager(VertxImpl vertx) {
   }
 
   private String generateDeploymentID() {
-    return UUID.randomUUID().toString();
+    if (vertx.isClustered() && vertx.haManager()!=null) {
+      // in this case we need a globally unique id
+      return UUID.randomUUID().toString();
+    }
+    // in the default case we want to generate the ID as fast as possible
+    return Long.valueOf(System.nanoTime()).toString();
   }
 
   public Future<Void> undeploy(String deploymentID) {

vertx-core/src/test/java/io/vertx/tests/file/FileResolverTestBase.java

@@ -477,12 +477,12 @@ public void testGetTheCacheDirWithoutHacks() {
     if (cacheDir != null) {
       assertTrue(cacheDir.startsWith(cacheBaseDir + "-"));
       // strip the remaining
-      String uuid = cacheDir.substring(cacheBaseDir.length() + 1);
+      String val = cacheDir.substring(cacheBaseDir.length() + 1);
       try {
-        UUID.fromString(uuid);
+        Long.parseLong(val);
         // OK
       } catch (Exception e) {
-        fail("Expected a UUID");
+        fail("Expected a Long");
       }
     }
   }