Skip to content

Commit f8a0b9f

Browse files
committed
Add missing createStream -> openStream rename in QuicConnectionInternal
1 parent c2b49a3 commit f8a0b9f

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

vertx-core/src/main/java/io/vertx/core/internal/quic/QuicConnectionInternal.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import io.vertx.core.Handler;
1818
import io.vertx.core.internal.ContextInternal;
1919
import io.vertx.core.net.QuicConnection;
20-
import io.vertx.core.net.QuicConnectionClose;
2120
import io.vertx.core.net.QuicStream;
2221

2322
import java.util.function.Consumer;
@@ -41,11 +40,11 @@ public interface QuicConnectionInternal extends QuicConnection {
4140
*/
4241
QuicConnectionInternal graceHandler(Handler<Void> handler);
4342

44-
Future<QuicStream> createStream(ContextInternal context);
43+
Future<QuicStream> openStream(ContextInternal context);
4544

46-
Future<QuicStream> createStream(ContextInternal context, boolean bidirectional);
45+
Future<QuicStream> openStream(ContextInternal context, boolean bidirectional);
4746

48-
Future<QuicStream> createStream(ContextInternal context, boolean bidirectional, Function<Consumer<QuicStreamChannel>, ChannelInitializer<QuicStreamChannel>> initializerProvider);
47+
Future<QuicStream> openStream(ContextInternal context, boolean bidirectional, Function<Consumer<QuicStreamChannel>, ChannelInitializer<QuicStreamChannel>> initializerProvider);
4948

5049
ChannelHandlerContext channelHandlerContext();
5150

vertx-core/src/main/java/io/vertx/core/net/impl/quic/QuicConnectionImpl.java

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
import java.util.concurrent.TimeUnit;
4242
import java.util.function.Consumer;
4343
import java.util.function.Function;
44-
import java.util.function.Supplier;
4544

4645
/**
4746
* @author <a href="mailto:[email protected]">Julien Viet</a>
@@ -197,29 +196,29 @@ public QuicConnection shutdownHandler(Handler<Duration> handler) {
197196
}
198197

199198
@Override
200-
public Future<QuicStream> createStream(ContextInternal context) {
201-
return createStream(context, true);
199+
public Future<QuicStream> openStream(ContextInternal context) {
200+
return openStream(context, true);
202201
}
203202

204203
@Override
205204
public Future<QuicStream> openStream(boolean bidirectional) {
206-
return createStream(vertx.getOrCreateContext(), bidirectional);
205+
return openStream(vertx.getOrCreateContext(), bidirectional);
207206
}
208207

209208
@Override
210-
public Future<QuicStream> createStream(ContextInternal context, boolean bidirectional) {
209+
public Future<QuicStream> openStream(ContextInternal context, boolean bidirectional) {
211210
Function<Consumer<QuicStreamChannel>, ChannelInitializer<QuicStreamChannel>> initializerProvider =
212211
quicStreamChannelConsumer -> new ChannelInitializer<>() {
213212
@Override
214213
protected void initChannel(QuicStreamChannel ch) throws Exception {
215214
quicStreamChannelConsumer.accept(ch);
216215
}
217216
};
218-
return createStream(context, bidirectional, initializerProvider);
217+
return openStream(context, bidirectional, initializerProvider);
219218
}
220219

221220
@Override
222-
public Future<QuicStream> createStream(ContextInternal context, boolean bidirectional, Function<Consumer<QuicStreamChannel>, ChannelInitializer<QuicStreamChannel>> initializerProvider) {
221+
public Future<QuicStream> openStream(ContextInternal context, boolean bidirectional, Function<Consumer<QuicStreamChannel>, ChannelInitializer<QuicStreamChannel>> initializerProvider) {
223222
Promise<QuicStream> promise = context.promise();
224223
VertxHandler<QuicStreamImpl> handler = VertxHandler.create(chctx -> new QuicStreamImpl(this, context, (QuicStreamChannel) chctx.channel(), streamMetrics, chctx));
225224
handler.addHandler(stream -> {

vertx-core/src/test/java/io/vertx/tests/net/quic/QuicContextTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ public void testStreamContextProvided() {
207207

208208
QuicConnection connection = client.connect(SocketAddress.inetSocketAddress(9999, "localhost")).await();
209209

210-
QuicStream stream = ((QuicConnectionInternal)connection).createStream(workerContext).await();
210+
QuicStream stream = ((QuicConnectionInternal)connection).openStream(workerContext).await();
211211

212212
AtomicInteger cnt = new AtomicInteger();
213213
stream.handler(buff -> {

0 commit comments

Comments
 (0)