-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Regression] - Connection should not process messages when in closed state #5340
Comments
A further observation: If you issue an HTTP2 request, it not just calls the request handler, but manages to return data to the client. This may be a timing issue, with the response being sent before the |
More observations: When using ALPN thus:
it honours the closed connection and works as expected. |
Here are my findings with various configurations of server using TLS & ALPN, and clients using HTTP1.1, HTTP1.1 upgrading to 2.0, and HTTP2.0 only. I hope this is useful: HTTPS
Edit: the above results are when the client uses ALPN. With that disabled, results are variable, with the same parameters producing different results for different runs. I suspect there may be timing issues there. HTTP
|
FWIW, here's a test to test for the issue:
|
@kitd thank I'll look at it |
Version
4.5.10
Context
There appears to be a regression of #3249 . When the connection is closed in the connection handler, the request continues to be dispatched to the request handlers.
Do you have a reproducer?
Steps to reproduce
CONNECTION CLOSED
message appears, theREQUEST HANDLER
message also appearsExtra
Linux Fedora 40
The text was updated successfully, but these errors were encountered: