-
Notifications
You must be signed in to change notification settings - Fork 160
Description
vertx-auth/vertx-auth-webauthn4j/src/main/java/io/vertx/ext/auth/webauthn4j/WebAuthn4J.java
Line 64 in f2fe958
Future<JsonObject> createCredentialsOptions(JsonObject user); |
vertx-auth/vertx-auth-webauthn4j/src/main/java/io/vertx/ext/auth/webauthn4j/WebAuthn4J.java
Line 76 in f2fe958
Future<JsonObject> getCredentialsOptions(@Nullable String username); |
The names of these methods are misleading.
When placed side by side, createCredentialsOptions
appears to be method that create CredentialsOptions
and getCredentialsOptions
appears to just return CredentialsOptions
.
However, they actually create PublicKeyCredentialCreationOptions
and PublicKeyCredentialGetOptions
, respectively.
Since introducing a new module vertx-auth-webauthn4j
is a good chance to make a breaking change from vertx-auth-webauthn
, I think these methods should be renamed to createPublicKeyCredentialCreationOptions
and createPublicKeyCredentialGetOptions
.