-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAD wavelengths are incorrectly called traces in the overlay #692
Comments
Internally, the term "trace" is used as a generic placeholder for m/z values or wavelengths. We should keep it internally as trace. But you're right, the front end labels might make a differentiation. |
Even internally it is called wavelength as far as I see: Line 19 in 9921848
|
Yep, correct :-). The layer on top, especially used in the template processor, uses "trace" as a synonym. |
Trace wavelength is a term in acoustics https://asastandards.org/Terms/trace-wavelength/ but not in analytical chemistry. |
This is somehow in between wrong and a polish problem. DAD wavelengths aren't traces which is confusing wording and the defaults like column bleeding mass traces from GC don't make any sense in LC-DAD scenarios. Someone who uses MS and DAD detectors at the same time might want to save user-defined settings for both without switching all the time in the chromatogram overlay.
The text was updated successfully, but these errors were encountered: