remove blank Javadoc #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
First, thanks for removing these javadoc warnings. To merge these changes and build/release, however, I have to manually update each bundle version in both the manifest.mf and the pom.xml for each effected project (i.e. every project that has a changed source file in it). For most changes I do this myself. but right now I'm not able to spend the time on it...to only remove javadocs warnings. So, if you are able to add in the necessary version updates of the effected projects to the pull request (both bundle and feature project versions) then I will merge this pull request. If you are not able at the moment, then it will probably have to wait for a month or so. |
|
I could do the version updates if the build would raise an error about missing updates. It does not even run tests and missing version updates are only logged as warning. Currently the build complains about many more version updates missing then i touched in this commit: |
|
Ok. Then this will wait. |
This commit cleans up Javadoc that does not add information. It resolves ecj warnings: `Javadoc: Description expected after ...` It helps to prevent future empty javadoc by disabling missingJavaDoc warnings. This resolves `Javadoc: Missing ...` The modification is a result of regular expression search&replace: in files `*.java` `^[\s]*\*[\s]*(@return|@param[\s]*[^\s]+|@throws[\s]*[^\s]+)\R([\s]*\*[\s]*@|[\s]*\*/\R)` ->`$2` `^([\s]*\*[\s]*\R)([\s]*\*/\R)` ->`$2` `^[\S\t ]*/\*\*\R[\s]*\*/\R` ->`` /\*\*\R \*/\R in files `org.eclipse.jdt.core.prefs` `org\.eclipse\.jdt\.core\.compiler\.problem\.missingJavadoc(Comments|Tags)\=[^\s]*` ->`org\.eclipse\.jdt\.core\.compiler\.problem\.missingJavadoc$1\=ignore`
|
@scottslewis i added version bump to my best knowledge, but the build fails with I don't understand the message. any idea how to solve this? |
|
Closing as it seems to be no interest in this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes ecj warning
"Javadoc: Description expected after this reference"