Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Core] Implemented StorableNotFoundException #4042

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented May 22, 2024

This PR introduces a new StorableNotFoundException meant to be thrown when a Storable is not found.
This exception is similar to KapuaEntityNotFountException, but for Storable classes.

Related Issue
None

Description of the solution adopted

  • Introduced new StorableNotFoundException
  • Implemented new Storable.getType api
  • Implemented StorableNotFoundExceptionMapper to handle error in REST API

Screenshots
None

Any side note on the changes made
None

@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 5.12821% with 37 lines in your changes missing coverage. Please review.

Project coverage is 16.67%. Comparing base (1835162) to head (c4e607c).

Current head c4e607c differs from pull request most recent head da423fb

Please upload reports for the commit da423fb to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #4042       +/-   ##
==============================================
+ Coverage           0   16.67%   +16.67%     
- Complexity         0       22       +22     
==============================================
  Files              0     2017     +2017     
  Lines              0    52221    +52221     
  Branches           0     4415     +4415     
==============================================
+ Hits               0     8707     +8707     
- Misses             0    43110    +43110     
- Partials           0      404      +404     
Files Coverage Δ
...service/storable/exception/StorableErrorCodes.java 100.00% <100.00%> (ø)
.../app/api/core/model/data/JsonDatastoreMessage.java 95.65% <0.00%> (ø)
...a/app/api/resources/v1/resources/DataChannels.java 0.00% <0.00%> (ø)
...ua/app/api/resources/v1/resources/DataClients.java 0.00% <0.00%> (ø)
...a/app/api/resources/v1/resources/DataMessages.java 0.00% <0.00%> (ø)
...ua/app/api/resources/v1/resources/DataMetrics.java 0.00% <0.00%> (ø)
...pse/kapua/service/datastore/model/ChannelInfo.java 0.00% <0.00%> (ø)
...ipse/kapua/service/datastore/model/ClientInfo.java 0.00% <0.00%> (ø)
...apua/service/datastore/model/DatastoreMessage.java 0.00% <0.00%> (ø)
...ipse/kapua/service/datastore/model/MetricInfo.java 0.00% <0.00%> (ø)
... and 5 more

... and 2002 files with indirect coverage changes

@Coduz Coduz force-pushed the feat-returnNotNullStorable branch 2 times, most recently from c4e607c to cb0339b Compare May 23, 2024 09:04
@Coduz Coduz marked this pull request as ready for review May 23, 2024 09:05
@Coduz Coduz marked this pull request as draft May 29, 2024 13:09
@Coduz Coduz force-pushed the feat-returnNotNullStorable branch from cb0339b to a4b5ed2 Compare June 6, 2024 09:28
@Coduz Coduz force-pushed the feat-returnNotNullStorable branch 2 times, most recently from 36e6ca2 to da423fb Compare June 25, 2024 14:03
@Coduz Coduz force-pushed the feat-returnNotNullStorable branch from da423fb to 6439a59 Compare September 23, 2024 14:44
@Coduz Coduz force-pushed the feat-returnNotNullStorable branch from 6439a59 to 29d41ce Compare October 8, 2024 08:06
@Coduz Coduz force-pushed the feat-returnNotNullStorable branch 2 times, most recently from 4add479 to cecd3cc Compare October 31, 2024 15:13
@Coduz Coduz force-pushed the feat-returnNotNullStorable branch from cecd3cc to 8bc723a Compare November 25, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
Status: In Progress
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant