Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break job engine to rest api dependency #4073

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from

Conversation

dseurotech
Copy link
Contributor

@dseurotech dseurotech commented Jul 3, 2024

This PR breaks the dependency that job-engine had to the rest-api, reorganising the commons-rest modules into a more structured commons-jersey modules (splitted in to rest and web submodules), that contain all the necessary components to handle jersey-based services (be they web apps or rest apis).

Breaking changes!

Also absorbs: #4017
This PR intends to clean up the internal dependencies between kapua modules. In most cases, it just cleans up the pom.xml files from dependencies which are already received transitively via maven (e.g.: if you already depend on the -internal module, it is implicit the dependence from the -api module).
In a few cases data classes have been moved closer to the project that use them -e.g.: IsJobRunningMultipleResponse.java is specific to the job engine and does not need to be in the commons-rest-model module.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 33.94495% with 72 lines in your changes missing coverage. Please review.

Project coverage is 16.63%. Comparing base (702bd78) to head (1435d79).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ommons/jersey/rest/model/IsJobRunningResponse.java 0.00% 12 Missing ⚠️
...ersey/rest/model/IsJobRunningMultipleResponse.java 0.00% 9 Missing ⚠️
...ommons/jersey/rest/filters/CORSResponseFilter.java 0.00% 7 Missing ⚠️
...ommons/jersey/rest/model/MultipleJobIdRequest.java 0.00% 5 Missing ⚠️
...apua/job/engine/client/JobEngineServiceClient.java 0.00% 5 Missing ⚠️
...mmons/jersey/rest/errors/KapuaExceptionMapper.java 0.00% 4 Missing ⚠️
...ersey/rest/errors/KapuaRuntimeExceptionMapper.java 0.00% 4 Missing ⚠️
...esources/v1/resources/DeviceManagementBundles.java 0.00% 4 Missing ⚠️
...rest/errors/KapuaDuplicateNameExceptionMapper.java 0.00% 3 Missing ⚠️
.../resources/v1/resources/ServiceConfigurations.java 0.00% 3 Missing ⚠️
... and 11 more
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4073      +/-   ##
=============================================
- Coverage      16.79%   16.63%   -0.17%     
  Complexity        22       22              
=============================================
  Files           2037     2029       -8     
  Lines          52835    52732     -103     
  Branches        4441     4437       -4     
=============================================
- Hits            8874     8772     -102     
+ Misses         43560    43558       -2     
- Partials         401      402       +1     
Files with missing lines Coverage Δ
...clipse/kapua/client/security/bean/AuthContext.java 0.00% <ø> (ø)
...ersey/rest/ExceptionConfigurationProviderImpl.java 0.00% <ø> (ø)
...kapua/commons/jersey/rest/JaxbContextResolver.java 0.00% <ø> (ø)
...commons/jersey/rest/KapuaCommonApiCoreSetting.java 100.00% <100.00%> (ø)
...ons/jersey/rest/KapuaCommonApiCoreSettingKeys.java 100.00% <100.00%> (ø)
...mmons/jersey/rest/KapuaSerializableBodyWriter.java 100.00% <ø> (ø)
...ipse/kapua/commons/jersey/rest/ListBodyWriter.java 100.00% <ø> (ø)
...ons/jersey/rest/MoxyJsonConfigContextResolver.java 100.00% <ø> (ø)
...e/kapua/commons/jersey/rest/RestApiErrorCodes.java 100.00% <ø> (ø)
...a/commons/jersey/rest/RestApiRuntimeException.java 100.00% <ø> (ø)
... and 150 more

... and 16 files with indirect coverage changes

@dseurotech dseurotech force-pushed the ref-break_job_engine_to_rest_api_dependency branch from 6f4b47c to 37406a1 Compare August 1, 2024 08:53
…if activated it failed compilation without any debug information

Signed-off-by: dseurotech <[email protected]>
…generic, neither used anywhere else

Signed-off-by: dseurotech <[email protected]>
Signed-off-by: dseurotech <[email protected]>
…ne-app-web as it was not generic, neither used anywhere else"

This reverts commit 3450f05.
Signed-off-by: dseurotech <[email protected]>
…, as the dependency was broken

Signed-off-by: dseurotech <[email protected]>
…generic, neither used anywhere else

Signed-off-by: dseurotech <[email protected]>
…ne-app-web as it was not generic, neither used anywhere else"

This reverts commit 3450f05.
@dseurotech dseurotech force-pushed the ref-break_job_engine_to_rest_api_dependency branch from 37406a1 to 92d3e20 Compare December 3, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant