Break job engine to rest api dependency#4073
Open
dseurotech wants to merge 31 commits intoeclipse-kapua:developfrom
Open
Break job engine to rest api dependency#4073dseurotech wants to merge 31 commits intoeclipse-kapua:developfrom
dseurotech wants to merge 31 commits intoeclipse-kapua:developfrom
Conversation
6f4b47c to
37406a1
Compare
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
…if activated it failed compilation without any debug information Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
…generic, neither used anywhere else Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
… exist) Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
…encies a little bit" This reverts commit 5bd0938.
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
…ne-app-web as it was not generic, neither used anywhere else" This reverts commit 3450f05.
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
…, as the dependency was broken Signed-off-by: dseurotech <davide.salvador@eurotech.com>
…generic, neither used anywhere else Signed-off-by: dseurotech <davide.salvador@eurotech.com>
…ne-app-web as it was not generic, neither used anywhere else" This reverts commit 3450f05.
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
…common code in commons-rest Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
… soup Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Signed-off-by: dseurotech <davide.salvador@eurotech.com>
37406a1 to
92d3e20
Compare
…lute other rest apis Signed-off-by: dseurotech <davide.salvador@eurotech.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR breaks the dependency that job-engine had to the rest-api, reorganising the commons-rest modules into a more structured commons-jersey modules (splitted in to rest and web submodules), that contain all the necessary components to handle jersey-based services (be they web apps or rest apis).
Breaking changes!
Also absorbs: #4017
This PR intends to clean up the internal dependencies between kapua modules. In most cases, it just cleans up the pom.xml files from dependencies which are already received transitively via maven (e.g.: if you already depend on the -internal module, it is implicit the dependence from the -api module).
In a few cases data classes have been moved closer to the project that use them -e.g.: IsJobRunningMultipleResponse.java is specific to the job engine and does not need to be in the commons-rest-model module.