Complicated if statement

[kctezcan]

What happened?

WeatherGenerator/src/weathergen/datasets/multi_stream_data_sampler.py

Line 631 in 4ef6e3e

if "student_teacher" in mode or mode == "latent_loss" in mode:

The if statement seems to do some complicated check, which seems to be incorrect. Please verify @clessig @shmh40

What are the steps to reproduce the bug?

No response

Hedgedoc link to logs and more information. This ticket is public, do not attach files directly.

No response

[TillHae]

Yes, this should be changed. What the second part of the if statement does (mode == "latent_loss" in mode) is to first check if "latent_loss" is in mode as comparisons are executed almost always as the last operation. This then returns a boolean and checks if mode also has this value. As mode is not a dictionary this part is always evaluated as False.

[clessig]

It should be if "student_teacher" in mode or "latent_loss" in mode. Can you open a quick PR to fix this. Thanks!