Skip to content

Commit 6f58fcf

Browse files
anaprietonemgmertes
authored andcommitted
fix: Reverting change to include dependency of mlflow-export-import to unblock pypi releases (#775)
## Description https://github.com/ecmwf/anemoi-core/actions/runs/20342675367 - Current pypi releases are blocked because of https://github.com/ecmwf/anemoi-core/pull/748/changes where 'mlflow-export-import' was added to the pyproject.toml as a dependency. Because the package is poorly maintained and don't have releases we used the git+https. According to https://til.dchan.cc/posts/11-29-2022/ and the error, this blocks the release to pypi. ## What problem does this change solve? (https://github.com/ecmwf/anemoi-core/actions/runs/20342675367) ## What issue or task does this change relate to? <!-- link to Issue Number --> ## Additional notes ## <!-- Include any additional information, caveats, or considerations that the reviewer should be aware of. --> ***As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/*** By opening this pull request, I affirm that all authors agree to the [Contributor License Agreement.](https://github.com/ecmwf/codex/blob/main/Legal/contributor_license_agreement.md) (cherry picked from commit f7d2acc)
1 parent 25b3f7a commit 6f58fcf

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

training/pyproject.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,6 @@ optional-dependencies.docs = [
7979
"sphinx-argparse",
8080
"sphinx-rtd-theme",
8181
]
82-
optional-dependencies.mlflowsync = [
83-
"mlflow-export-import @ git+https://github.com/mlflow/mlflow-export-import.git@master",
84-
]
8582
optional-dependencies.plotting = [
8683
"distinctipy>=1",
8784
]

training/src/anemoi/training/utils/mlflow_sync.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def close_and_clean_temp(server2server: str, artifact_path: Path) -> None:
7373
except ImportError:
7474
msg = (
7575
"The 'mlflow-export-import' package is not installed."
76-
"You can install it doing pip install anemoi-training[mlflowsync]"
76+
"Please install it from https://github.com/mlflow/mlflow-export-import"
7777
)
7878
raise ImportError(msg) from None
7979

0 commit comments

Comments
 (0)