-
Notifications
You must be signed in to change notification settings - Fork 78
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Is your feature request related to a problem? Please describe.
Currently the codebase is hardcoded:
training has shuffle= True
validation has shuffle = False
test has shuffle = False
Describe the solution you'd like
These should be extended to allow more flexibility in experiments:
@cached_property
def ds_train(self) -> MultiDataset:
"""Create multi-dataset for training."""
return self._get_dataset(
self.train_dataloader_config,
shuffle=True,
label="training",
)
@cached_property
def ds_valid(self) -> MultiDataset:
"""Create multi-dataset for validation."""
return self._get_dataset(
self.valid_dataloader_config,
shuffle=False,
val_rollout=self.config.dataloader.validation_rollout,
label="validation",
)
@cached_property
def ds_test(self) -> MultiDataset:
"""Create multi-dataset for testing."""
return self._get_dataset(self.test_dataloader_config, shuffle=False, label="test")
Describe alternatives you've considered
No response
Additional context
No response
Organisation
No response
mchantry
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request
Type
Projects
Status
To be triaged