Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fill="none" for fill="#fff" for background color #878

Open
shinokada opened this issue Oct 31, 2024 · 4 comments
Open

Use fill="none" for fill="#fff" for background color #878

shinokada opened this issue Oct 31, 2024 · 4 comments

Comments

@shinokada
Copy link

shinokada commented Oct 31, 2024

These days developers use dark/light/system modes. If you have fill="#fff", you have the white bg when the mode is dark.

For example, bluesky has it.

// this line
<path d="m0 0H512V512H0" fill="#fff" />
// to 
<path d="m0 0H512V512H0" fill="none" />
// or
<path d="m0 0H512V512H0" fill="transparent" />
@edent
Copy link
Owner

edent commented Oct 31, 2024

That's an interesting idea. Could you please show a screenshot comparing them?

@shinokada
Copy link
Author

The following screenshots are on the dark mode.

With fill="none"
image

With fill="#fff"
image

@edent
Copy link
Owner

edent commented Oct 31, 2024

Looks good. Are there any icons where the background colour forms part of the logo?

@shinokada
Copy link
Author

shinokada commented Oct 31, 2024

There are many SVG icons have <path d="m0 0H512V512H0" fill="#fff" />.

https://github.com/edent/SuperTinyIcons/tree/master/images/svg

You can see all the icons at https://svelte-supertiny.codewithshin.com/icons. You will find may icons have white background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants