Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated Deno APIs #844

Open
NetOpWibby opened this issue Jan 29, 2024 · 7 comments · May be fixed by #869
Open

Deprecated Deno APIs #844

NetOpWibby opened this issue Jan 29, 2024 · 7 comments · May be fixed by #869
Labels
good first issue upstream:deno

Comments

@NetOpWibby
Copy link

Describe the bug
The Deno client library is using APIs that will be removed from Deno soon

Reproduction
Run a Deno application using EdgeDB

Expected behavior
No deprecation warnings

Versions (please complete the following information):

  • OS: macOS Sonoma 14.2.1
  • EdgeDB version (e.g. 2.0): 4.4+aa576e1
  • EdgeDB CLI version (e.g. 2.0): 4.0.2+500be79
  • Deno version: 1.40.2

Additional context

⚠️  The `--unstable` flag is deprecated and will be removed in Deno 2.0. Use granular `--unstable-*` flags instead.
Learn more at: https://docs.deno.com/runtime/manual/tools/unstable_flags
warning: Use of deprecated "Deno.stderr.rid" API. This API will be removed in Deno 2. Run again with DENO_VERBOSE_WARNINGS=1 to get more details.
warning: Use of deprecated "Deno.isatty()" API. This API will be removed in Deno 2. Run again with DENO_VERBOSE_WARNINGS=1 to get more details.
warning: Use of deprecated "Deno.stdout.rid" API. This API will be removed in Deno 2. Run again with DENO_VERBOSE_WARNINGS=1 to get more details.
warning: Use of deprecated "Deno.stdin.rid" API. This API will be removed in Deno 2. Run again with DENO_VERBOSE_WARNINGS=1 to get more details.
@scotttrinh
Copy link
Collaborator

@NetOpWibby

Do you have any idea where those four APIs are being used in the client? I wasn't able to find any references to them when I grep'd for them across the whole codebase. I wonder if they're coming from some pinned dependencies in the standard Deno library? I'll keep looking around, but I was hoping to just knock it out real quick, but no such luck.

@NetOpWibby
Copy link
Author

Hmm, it could be possible these were from my own project but I saw these errors when running that command for regenerating the client library. Could be some other dependency I'm using. I'll check more in-depth today.

@NetOpWibby
Copy link
Author

My apologies for the lateness! I ran my project with DENO_VERBOSE_WARNINGS=1 and it provided a stack trace of where the issues stem from...Deno's own std library LOL.

@scotttrinh
Copy link
Collaborator

@NetOpWibby

I assume that means it's coming from our pinned versions from the std library. Do you mind providing some of the output from DENO_VERBOSE_WARNINGS so we can look into bumping our std dependencies. I'm going to reopen to consider this as a tracking issue for ensuring we're ready for Deno 2.

@scotttrinh scotttrinh reopened this Jan 31, 2024
@1st1
Copy link
Member

1st1 commented Jan 31, 2024

Deno's own std library LOL.

Lol indeed.

@NetOpWibby
Copy link
Author

@scotttrinh Here you go!

DENO_VERBOSE_WARNINGS=1 denon start --development
⚠️  The `--unstable` flag is deprecated and will be removed in Deno 2.0. Use granular `--unstable-*` flags instead.
Learn more at: https://docs.deno.com/runtime/manual/tools/unstable_flags
[*] [main] v2.5.0
[*] [daem] watching path(s): **/*.*
[*] [daem] watching extensions: ts,tsx,js,jsx,json
[!] [#0] starting `deno run --allow-env --allow-net --allow-read --import-map import_map.json main.ts --development`
warning: Use of deprecated "Deno.stderr.rid" API. This API will be removed in Deno 2.

Stack trace:
  at createWritableStdioStream (https://deno.land/[email protected]/node/_process/streams.mjs:36:21)
  at https://deno.land/[email protected]/node/_process/streams.mjs:94:38

hint: Use `Deno.stderr` instance methods instead.
hint: It appears this API is used by a remote dependency. Try upgrading to the latest version of that dependency.

warning: Use of deprecated "Deno.stderr.rid" API. This API will be removed in Deno 2.

Stack trace:
  at createWritableStdioStream (https://deno.land/[email protected]/node/_process/streams.mjs:68:27)
  at https://deno.land/[email protected]/node/_process/streams.mjs:94:38

hint: Use `Deno.stderr` instance methods instead.
hint: It appears this API is used by a remote dependency. Try upgrading to the latest version of that dependency.

warning: Use of deprecated "Deno.isatty()" API. This API will be removed in Deno 2.

Stack trace:
  at createWritableStdioStream (https://deno.land/[email protected]/node/_process/streams.mjs:68:20)
  at https://deno.land/[email protected]/node/_process/streams.mjs:94:38

hint: Use `Deno.stdin.isTerminal()`, `Deno.stdout.isTerminal()` or `Deno.stderr.isTerminal()` instead.
hint: It appears this API is used by a remote dependency. Try upgrading to the latest version of that dependency.

warning: Use of deprecated "Deno.stdout.rid" API. This API will be removed in Deno 2.

Stack trace:
  at createWritableStdioStream (https://deno.land/[email protected]/node/_process/streams.mjs:36:21)
  at https://deno.land/[email protected]/node/_process/streams.mjs:100:38

hint: Use `Deno.stdout` instance methods instead.
hint: It appears this API is used by a remote dependency. Try upgrading to the latest version of that dependency.

warning: Use of deprecated "Deno.stdout.rid" API. This API will be removed in Deno 2.

Stack trace:
  at createWritableStdioStream (https://deno.land/[email protected]/node/_process/streams.mjs:68:27)
  at https://deno.land/[email protected]/node/_process/streams.mjs:100:38

hint: Use `Deno.stdout` instance methods instead.
hint: It appears this API is used by a remote dependency. Try upgrading to the latest version of that dependency.

warning: Use of deprecated "Deno.isatty()" API. This API will be removed in Deno 2.

Stack trace:
  at createWritableStdioStream (https://deno.land/[email protected]/node/_process/streams.mjs:68:20)
  at https://deno.land/[email protected]/node/_process/streams.mjs:100:38

hint: Use `Deno.stdin.isTerminal()`, `Deno.stdout.isTerminal()` or `Deno.stderr.isTerminal()` instead.
hint: It appears this API is used by a remote dependency. Try upgrading to the latest version of that dependency.

warning: Use of deprecated "Deno.stdin.rid" API. This API will be removed in Deno 2.

Stack trace:
  at https://deno.land/[email protected]/node/_process/streams.mjs:164:24
  at https://deno.land/[email protected]/node/_process/streams.mjs:224:3

hint: Use `Deno.stdin` instance methods instead.
hint: It appears this API is used by a remote dependency. Try upgrading to the latest version of that dependency.

warning: Use of deprecated "Deno.isatty()" API. This API will be removed in Deno 2.

Stack trace:
  at _guessStdinType (https://deno.land/[email protected]/node/_process/streams.mjs:110:20)
  at https://deno.land/[email protected]/node/_process/streams.mjs:166:21
  at https://deno.land/[email protected]/node/_process/streams.mjs:224:3

hint: Use `Deno.stdin.isTerminal()`, `Deno.stdout.isTerminal()` or `Deno.stderr.isTerminal()` instead.
hint: It appears this API is used by a remote dependency. Try upgrading to the latest version of that dependency.

warning: Use of deprecated "Deno.stdin.rid" API. This API will be removed in Deno 2.

Stack trace:
  at https://deno.land/[email protected]/node/_process/streams.mjs:226:22

hint: Use `Deno.stdin` instance methods instead.
hint: It appears this API is used by a remote dependency. Try upgrading to the latest version of that dependency.

@scotttrinh scotttrinh linked a pull request Feb 16, 2024 that will close this issue
Draft
@NetOpWibby
Copy link
Author

Tagging onto this issue to state that the query builder doesn't know about branches yet. Also, the repo for the Deno module states v1.3.0 as the latest version when it's supposed to be v1.4.1. I feel like the issue was something about automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue upstream:deno
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use latest Deno std and node: specifiers edgedb/edgedb-js
3 participants
@1st1 @NetOpWibby @scotttrinh