Introduce client.withCodecs() #1161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
force-pushed
the
withCodecs
branch
2 times, most recently
from
339f2d2 to
ed1786d
Compare
jaclarke
reviewed
Jan 10, 2025
jaclarke
reviewed
Jan 10, 2025
jaclarke
reviewed
Jan 10, 2025
jaclarke
reviewed
Jan 10, 2025
scotttrinh
reviewed
Jan 10, 2025
Comment on lines
+97
to
+98
| // TODO: Figure out if we can drop the dep | ||
| // on an external package for Float16Array. |
There was a problem hiding this comment.
Unfortunately not: only Deno, Firefox, and Safari support native Float16Array
There was a problem hiding this comment.
We can emulate is in a very very limited way the same way that third party library does. I just want us to "own" the type we'd be proxying through our API.
There was a problem hiding this comment.
Sure, you mean basically vendor the existing library? We can also just use Float32Array until there is better support for Float16Array.
There was a problem hiding this comment.
I've looked at that implementation, it's huge and complicated :/ Vendoring is an option
This will make a nicer foundation for the upcoming withCodecs API, as I plan to start passing Options into the codecs machinery. Along the way, I refactored Options to ensure they are fully immutable and use proper collections types. One specific thing I wanted to fix is avoiding using `=== defaults()` checks as they are flaky.
This can give a noticeable perf boost in a regular use case scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft
ToDo:
setCustomCodecs