Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the configured passwordResetUrl in auth-nextjs #784

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

MiroslavPetrik
Copy link
Contributor

When requesting the reset password email, the URL from config is used, but was not really set during auth initialization.
The resetUrl param is not supported, so I've removed it from the type.

@MiroslavPetrik
Copy link
Contributor Author

@scotttrinh I see that only the links for the builtin signin/signout are exposed via helper methods. Will there be such methods for the rest of the urls, like the password reset email?

I can imagine, that for custom UI I would ship initially just the Sign in and sign out screens, and for the password flows I would fallback to the default ui. That way, I can progressively ship just the screens which users use the most and fallback to default for the infrequent flows.

When requesting reset password email, the URL from config is used, but was not really set during `auth` initialization.
the `resetUrl` param is not supported, so I've removed it from the type.
@scotttrinh
Copy link
Collaborator

I see that only the links for the builtin signin/signout are exposed via helper methods. Will there be such methods for the rest of the urls, like the password reset email?

I don't think that's currently planned since those links have been considered internal and subject to change. Perhaps in the future we might be alright with stabilizing those internal routes, but in the meantime you're welcome to link to them as long as you realize that they're subject to breaking changes in minor versions.

I can imagine, that for custom UI I would ship initially just the Sign in and sign out screens, and for the password flows I would fallback to the default ui. That way, I can progressively ship just the screens which users use the most and fallback to default for the infrequent flows.

Yeah, I can see the value in that approach, although I think it's pretty likely that the cost of building those few screens yourself is probably worth it to match the design and feel of the sign in and sign up pages. It would feel jarring for them to be so different, and if they were very similar, I'm not sure it makes sense that you would do something so similar but make it custom.

@scotttrinh scotttrinh merged commit eb7fa07 into edgedb:master Nov 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants