Skip to content
This repository has been archived by the owner on Apr 9, 2020. It is now read-only.

iOS app crashes when switching tours #102

Open
jollopre opened this issue Dec 13, 2017 · 7 comments
Open

iOS app crashes when switching tours #102

jollopre opened this issue Dec 13, 2017 · 7 comments
Assignees
Labels

Comments

@jollopre
Copy link
Contributor

Anytime a tour is switched and the user taps on any marker, the app crashes.

Scenario:

  • Open the app with the default tour
  • Change tour
  • Tap any marker

It might be related to #95

@jollopre jollopre added the IOS label Dec 13, 2017
@jollopre jollopre added this to the Release 2.1 Snagging milestone Dec 13, 2017
@jollopre jollopre self-assigned this Dec 13, 2017
jollopre pushed a commit that referenced this issue Dec 13, 2017
…rting null, i.e. when a component is unmmounted. #102
@jollopre jollopre mentioned this issue Dec 13, 2017
@adrianczuczka
Copy link
Contributor

I think this issue was fully fixed in my pull request, even though it might be good to check on iPhone, since I could only test it on Android.

@NicolaOsborne
Copy link

Adrian, I'm afraid this is still an issue on iOS - have just tested and confirmed this. Happy for you to use my phone to view and then test the fix.

@adrianczuczka
Copy link
Contributor

I see, then that would be great, as I don't have an iPhone at my disposal.

@adrianczuczka
Copy link
Contributor

I added another commit to fix a problem with setting markers' zIndexes, and it should now correctly update them. Again, it is probably good to try it on iPhone but it does work on Android. My changes are in my fork, in branch "issue-102-app-crashes", so you can clone that and try it. I'll also open an issue regarding the back button functionality on Android (and workarounds on iOS) if that's ok.

@NicolaOsborne
Copy link

@adrianczuczka @jollopre I presume we will we need to issue a new app update to get this onto our users devices?

@adrianczuczka
Copy link
Contributor

We might want to wait a bit because I'm working on the UI right now, so if you guys will agree with the changes I'll make, we can issue a big update rather than many small ones

@NicolaOsborne
Copy link

This has been tested again in Test Flight and the crashing persists.

ianfieldhouse added a commit that referenced this issue Aug 7, 2018
…-marker-callout

#102 Crash on iOS when viewing marker callout
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants