Skip to content

Commit 3af9378

Browse files
authored
feat!: remove temporary rollout span tag code_owner_plugin (#873)
The span tag code_owner_plugin was used to rollout code_owner switch from edx-django-utils to the datadog_monitoring plugin in this repo. Now that rollout is complete, this span tag can be removed. Implements: - #784
1 parent 138ed0e commit 3af9378

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

CHANGELOG.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ Change Log
1313
1414
Unreleased
1515
~~~~~~~~~~
16+
Removed
17+
-------
18+
* Removed temporary rollout span tag ``code_owner_plugin`` used for the code owner monitoring move from edx-django-utils. Now that edx-django-utils monitoring has been disabled, this span tag serves no purpose.
1619

1720
[6.1.0] - 2024-12-10
1821
~~~~~~~~~~~~~~~~~~~~

edx_arch_experiments/datadog_monitoring/code_owner/utils.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -136,15 +136,6 @@ def set_code_owner_custom_span_tags(code_owner):
136136
# to the code_owner span tag.
137137
set_custom_attribute('code_owner_squad', code_owner)
138138

139-
# .. custom_attribute_name: code_owner_plugin
140-
# .. custom_attribute_description: This is a temporary span tag to roll out the
141-
# the switch from edx-django-utils to this plugin. If this span tag is True,
142-
# the plugin has added the above custom span tags (possibly in addition to
143-
# edx-django-utils). If the code_owner_theme span tag is also seen, then
144-
# edx-django-utils is also adding these span tags. If not, only the plugin is
145-
# creating these tags.
146-
set_custom_attribute('code_owner_plugin', True)
147-
148139

149140
def set_code_owner_span_tags_from_request(request):
150141
"""

edx_arch_experiments/datadog_monitoring/tests/code_owner/test_utils.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,6 @@ def _assert_set_custom_attribute(
169169
if code_owner:
170170
call_list.append(call('code_owner', code_owner))
171171
call_list.append(call('code_owner_squad', code_owner))
172-
call_list.append(call('code_owner_plugin', True))
173172
if module:
174173
call_list.append(call('code_owner_module', module))
175174
if has_path_error:

0 commit comments

Comments
 (0)