Have SAMLProviderConfig point to the most current version of SAMLConfiguration

[dianakhuang]

We ran into a bug in production because SAMLProviderConfig was pointing to an older version of a SAMLConfiguration. This is partially because SAMLProviderConfig only has a ForeignKey to SAMLConfiguration (updated permalink). We would like to have this automatically point to the latest version instead of requiring a manual update to ensure that SAMLConfigurations reflect the actual changes.

[robrap]

The way config models work, you should always be picking up the newest version. Storing a particular version of a config model in another config model was probably just an incorrect design based on not fully understanding how config models work.

[robrap]

Here is a more detailed explanation of my earlier comment:

• A ConfigModel tracks its history of changes, but only for auditing purposes. When using a ConfigModel, only its latest value should be used, not any historical versioned value.
• Therefore, in place of storing a version of the config model (which should be cleaned up in a later step), we should simply request the latest/active value of the config model when it gets used.

[robrap]

[question]:

• In the following or-statement in SAMLProviderConfig in

conf['saml_sp_configuration'] = (
            self.saml_configuration or
            SAMLConfiguration.current(self.site.id, 'default')
        )

• Would self.saml_configuration be different from SAMLConfiguration.current(self.site.id, 'default')?
• I'm not clear on what the former (self.saml_configuration) was added for.
• If it is used to connect to a different SAMLConfiguration, do we have enough information in SAMLProviderConfig to do a SAMLConfiguration.current(...) look-up?
• If not, would a hacky solution be to use self.saml_configuration to get an appropriate filter to make an additional call to current(...)?

[ktyagiapphelix2u]

Raised a PR to address and improve the SAML configuration retrieval logic: Enhance SAML configuration retrieval logic in SAMLProviderConfig (#36874).
The changes aim to make the retrieval process more reliable and maintainable. Please take a moment to review it when convenient—your feedback is appreciated!

[robrap]

@ktyagiapphelix2u: The link in your comment above is broken. It should be:

• fix: Enhance SAML configuration retrieval logic in SAMLProviderConfig openedx/edx-platform#36874